Skip to content

Conversation

@steakhal
Copy link
Contributor

@steakhal steakhal commented Sep 9, 2025

This was likely accidentally omitted when liveBindings was introduced. I don't think in practice it matters.

This was likely accidentally omitted when `liveBindings` was introduced.
I don't think in practice it matters.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:analysis labels Sep 9, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 9, 2025

@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-analysis

@llvm/pr-subscribers-clang-static-analyzer-1

Author: Balazs Benics (steakhal)

Changes

This was likely accidentally omitted when liveBindings was introduced. I don't think in practice it matters.


Full diff: https://github.com/llvm/llvm-project/pull/157645.diff

1 Files Affected:

  • (modified) clang/lib/Analysis/LiveVariables.cpp (+2-1)
diff --git a/clang/lib/Analysis/LiveVariables.cpp b/clang/lib/Analysis/LiveVariables.cpp
index 375fdb3695e2f..db88d4f7ee0f7 100644
--- a/clang/lib/Analysis/LiveVariables.cpp
+++ b/clang/lib/Analysis/LiveVariables.cpp
@@ -128,7 +128,8 @@ LiveVariablesImpl::merge(LiveVariables::LivenessValues valsA,
 }
 
 bool LiveVariables::LivenessValues::equals(const LivenessValues &V) const {
-  return liveExprs == V.liveExprs && liveDecls == V.liveDecls;
+  return liveExprs == V.liveExprs && liveDecls == V.liveDecls &&
+         liveBindings == V.liveBindings;
 }
 
 //===----------------------------------------------------------------------===//

@steakhal steakhal enabled auto-merge (squash) September 9, 2025 11:13
@steakhal steakhal merged commit bf5ea87 into llvm:main Sep 9, 2025
13 checks passed
@steakhal steakhal deleted the bb/fix branch September 9, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:analysis clang:static analyzer clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants