Skip to content

[HLSL] Add the Frs DXC driver option #157690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2025
Merged

[HLSL] Add the Frs DXC driver option #157690

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0831e99
[HLSL] Add the `Frs` driver option
inbelic Sep 9, 2025
11c141f
self-review: update old arg name
inbelic Sep 9, 2025
7198a1e
review: comment nit
inbelic Sep 9, 2025
a90b868
Merge branch 'main' into inbelic/frs
inbelic Sep 9, 2025
db31369
clang format
inbelic Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/include/clang/Driver/Options.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9418,6 +9418,8 @@ def dxc_Fo : DXCJoinedOrSeparate<"Fo">,
HelpText<"Output object file">;
def dxc_Fc : DXCJoinedOrSeparate<"Fc">,
HelpText<"Output assembly listing file">;
def dxc_Frs : DXCJoinedOrSeparate<"Frs">,
HelpText<"Output additional root signature object file">;
def dxil_validator_version : Option<["/", "-"], "validator-version", KIND_SEPARATE>,
Group<dxc_Group>, Flags<[HelpHidden]>,
Visibility<[DXCOption, ClangOption, CC1Option]>,
Expand Down
9 changes: 8 additions & 1 deletion clang/lib/Driver/ToolChains/HLSL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,13 @@ void tools::hlsl::LLVMObjcopy::ConstructJob(Compilation &C, const JobAction &JA,
CmdArgs.push_back(Output.getFilename());

if (Args.hasArg(options::OPT_dxc_strip_rootsignature)) {
const char *Frs = Args.MakeArgString("--remove-section=RTS0");
const char *StripRS = Args.MakeArgString("--remove-section=RTS0");
CmdArgs.push_back(StripRS);
}

if (Arg *Arg = Args.getLastArg(options::OPT_dxc_Frs)) {
const char *Frs =
Args.MakeArgString("--extract-section=RTS0=" + Twine(Arg->getValue()));
CmdArgs.push_back(Frs);
}

Expand Down Expand Up @@ -524,6 +530,7 @@ bool HLSLToolChain::requiresBinaryTranslation(DerivedArgList &Args) const {
bool HLSLToolChain::requiresObjcopy(DerivedArgList &Args) const {
return Args.hasArg(options::OPT_dxc_Fo) &&
(Args.hasArg(options::OPT_dxc_strip_rootsignature) ||
Args.hasArg(options::OPT_dxc_Frs) ||
isRootSignatureTarget(Args));
}

Expand Down
10 changes: 10 additions & 0 deletions clang/test/Driver/dxc_frs.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// RUN: %clang_dxc -T cs_6_0 /Fo %t.dxo /Frs %t.rs.dxo -### %s 2>&1 | FileCheck %s

// Test to demonstrate extracting the root signature to the specified
// output file with /Frs.

// CHECK: "{{.*}}llvm-objcopy{{(.exe)?}}" "{{.*}}.obj" "{{.*}}.dxo" "--extract-section=RTS0={{.*}}.rs.dxo"

[shader("compute"), RootSignature("")]
[numthreads(1,1,1)]
void EmptyEntry() {}
Loading