- 
                Notifications
    
You must be signed in to change notification settings  - Fork 15.1k
 
[libc] Add check for support and a test for libc SIMD helpers #157746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #include "src/__support/macros/attributes.h" | ||
| 
     | 
||
| #if !LIBC_HAS_VECTOR_TYPE | ||
| #error unsupported | ||
| #endif | ||
| 
     | 
||
| bool [[clang::ext_vector_type(1)]] v; | 
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| //===-- Unittests for cpp::simd -------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| 
     | 
||
| #include "src/__support/CPP/simd.h" | ||
| #include "src/__support/CPP/utility.h" | ||
| 
     | 
||
| #include "test/UnitTest/FPMatcher.h" | ||
| #include "test/UnitTest/Test.h" | ||
| 
     | 
||
| static_assert(LIBC_HAS_VECTOR_TYPE, "compiler needs ext_vector_type support"); | ||
| 
     | 
||
| using namespace LIBC_NAMESPACE::cpp; | ||
| 
     | 
||
| TEST(LlvmLibcSIMDTest, Basic) {} | ||
| TEST(LlvmLibcSIMDTest, VectorCreation) { | ||
| simd<int> v1 = splat(5); | ||
| simd<int> v2 = iota<int>(); | ||
| 
     | 
||
| EXPECT_EQ(v1[0], 5); | ||
| EXPECT_EQ(v2[0], 0); | ||
| } | ||
| 
     | 
||
| TEST(LlvmLibcSIMDTest, TypeTraits) { | ||
| simd<int> v1 = splat(0); | ||
| 
     | 
||
| static_assert(is_simd_v<decltype(v1)>, "v1 should be a SIMD type"); | ||
| static_assert(!is_simd_v<int>, "int is not a SIMD type"); | ||
| static_assert(is_simd_mask_v<simd<bool, 4>>, "should be a SIMD mask"); | ||
| 
     | 
||
| using Elem = simd_element_type_t<decltype(v1)>; | ||
| static_assert(is_same_v<Elem, int>, "element type should be int"); | ||
| } | ||
| 
     | 
||
| TEST(LlvmLibcSIMDTest, ElementwiseOperations) { | ||
| simd<int> v1 = splat(1); | ||
| simd<int> v2 = splat(-1); | ||
| 
     | 
||
| simd<int> v_abs = abs(v2); | ||
| simd<int> v_min = min(v1, v2); | ||
| simd<int> v_max = max(v1, v2); | ||
                
       | 
||
| 
     | 
||
| EXPECT_EQ(v_min[0], -1); | ||
| EXPECT_EQ(v_max[0], 1); | ||
| EXPECT_EQ(v_abs[0], 1); | ||
| } | ||
| 
     | 
||
| TEST(LlvmLibcSIMDTest, ReductionOperations) { | ||
| simd<int> v = splat(1); | ||
| 
     | 
||
| int sum = reduce(v); | ||
| int prod = reduce(v, multiplies<>{}); | ||
| 
     | 
||
| EXPECT_EQ(sum, static_cast<int>(simd_size_v<decltype(v)>)); | ||
| EXPECT_EQ(prod, 1); | ||
| } | ||
| 
     | 
||
| TEST(LlvmLibcSIMDTest, MaskOperations) { | ||
| simd<bool, 8> mask{true, false, true, false, false, false, false, false}; | ||
| 
     | 
||
| EXPECT_TRUE(any_of(mask)); | ||
| EXPECT_FALSE(all_of(mask)); | ||
| EXPECT_TRUE(some_of(mask)); | ||
| EXPECT_EQ(find_first_set(mask), 0); | ||
| EXPECT_EQ(find_last_set(mask), 2); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to wrap the header library target for
simd.hin this check as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would I do for bazel with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, for the bazel we don't want the check. The cmake doesn't have to exactly match but leaving it out of the cmake is fine. When I get a chance I'll try to get the simd tests working in bazel, but that can be a separate patch.