Skip to content

[analyzer][NFC] Modernize LivenessValues::isLive #157800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steakhal merged 1 commit into from
Sep 10, 2025
Merged

[analyzer][NFC] Modernize LivenessValues::isLive #157800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions clang/lib/Analysis/LiveVariables.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,17 @@ bool LiveVariables::LivenessValues::isLive(const Expr *E) const {

bool LiveVariables::LivenessValues::isLive(const VarDecl *D) const {
if (const auto *DD = dyn_cast<DecompositionDecl>(D)) {
bool alive = false;
for (const BindingDecl *BD : DD->bindings())
alive |= liveBindings.contains(BD);

// Note: the only known case this condition is necessary, is when a bindig
// to a tuple-like structure is created. The HoldingVar initializers have a
// DeclRefExpr to the DecompositionDecl.
alive |= liveDecls.contains(DD);
return alive;
if (liveDecls.contains(DD))
return true;

for (const BindingDecl *BD : DD->bindings()) {
if (liveBindings.contains(BD))
return true;
}
return false;
}
return liveDecls.contains(D);
}
Expand Down