Skip to content

[LTO] Fix the issue of resetting the triple to default when it's empty #157829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2025
Merged

[LTO] Fix the issue of resetting the triple to default when it's empty #157829

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2741488
[LTO] Fix the issue of setting default triple when the triple is empty.
fzou1 Sep 10, 2025
5b49185
Add test
fzou1 Sep 10, 2025
68c1a95
Update test and rewrite to avoid constructing Triple from empty string
fzou1 Sep 11, 2025
036b628
Update test to check valid output
fzou1 Sep 11, 2025
e0ff115
Merge branch 'main' into lto_empty_triple
fzou1 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/lib/LTO/LTOCodeGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,9 @@ bool LTOCodeGenerator::determineTarget() {

TripleStr = MergedModule->getTargetTriple().str();
llvm::Triple Triple(TripleStr);
if (TripleStr.empty()) {
TripleStr = sys::getDefaultTargetTriple();
if (Triple.empty()) {
Triple = llvm::Triple(sys::getDefaultTargetTriple());
TripleStr = Triple.getTriple();
MergedModule->setTargetTriple(Triple);
Copy link
Contributor

@arsenm arsenm Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also rewrite this to avoid constructing the wrong triple to start with

Copy link
Contributor Author

@fzou1 fzou1 Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks.

}

Expand Down