Skip to content

[InstCombine] Improve foldDeadPhiWeb compile time #158057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2025
Merged

[InstCombine] Improve foldDeadPhiWeb compile time #158057

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a6bce6
[InstCombine] Improve `foldDeadPhiWeb` compile time
Enna1 Sep 10, 2025
e0d096f
clang format
Enna1 Sep 11, 2025
517bd7c
Merge branch 'main' into users/Enna1/perf/fold-dead-phi-web-opt-time
Enna1 Sep 11, 2025
f5657f2
fix...
Enna1 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions llvm/lib/Transforms/InstCombine/InstCombinePHI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ bool InstCombinerImpl::foldDeadPhiWeb(PHINode &PN) {
Stack.push_back(&PN);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add the initial phi node to the Visited set.

while (!Stack.empty()) {
PHINode *Phi = Stack.pop_back_val();
if (!Visited.insert(Phi).second)
continue;
// Early stop if the set of PHIs is large
if (Visited.size() == 16)
return false;
for (User *Use : Phi->users()) {
if (PHINode *PhiUse = dyn_cast<PHINode>(Use))
if (PHINode *PhiUse = dyn_cast<PHINode>(Use)) {
if (!Visited.insert(Phi).second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should insert PhiUse, not Phi.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry.. Fixed

continue;
// Early stop if the set of PHIs is large
if (Visited.size() >= 16)
return false;
Stack.push_back(PhiUse);
else
} else
return false;
}
}
Expand Down
Loading