Skip to content

[CI] include utils in monolithic scripts #158090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[CI] include utils in monolithic scripts #158090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73f72d3
[CI] Update monolithic-linux.sh
makslevental Sep 11, 2025
ca36022
Update monolithic-windows.sh
makslevental Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ci/monolithic-linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \
-D LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=ON \
-D CMAKE_INSTALL_PREFIX="${INSTALL_DIR}" \
-D CMAKE_EXE_LINKER_FLAGS="-no-pie" \
-D LLVM_ENABLE_WERROR=ON
-D LLVM_ENABLE_WERROR=ON \
-DLLVM_INSTALL_UTILS=ON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLVM_BUILD_UTILS and LLVM_INCLUDE_UTILS are already enabled by default. And we're not installing anything, so LLVM_INSTALL_UTILS shouldn't really do anything either. Overall I'm confused what difference this change actually makes.

Copy link
Contributor Author

@makslevental makslevental Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#157944 adds an install test. Also yes the first two are on by default but I thought it better to be explicit.


start-group "ninja"

Expand Down
3 changes: 2 additions & 1 deletion .ci/monolithic-windows.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \
-D CMAKE_EXE_LINKER_FLAGS="/MANIFEST:NO" \
-D CMAKE_MODULE_LINKER_FLAGS="/MANIFEST:NO" \
-D CMAKE_SHARED_LINKER_FLAGS="/MANIFEST:NO" \
-D LLVM_ENABLE_RUNTIMES="${runtimes}"
-D LLVM_ENABLE_RUNTIMES="${runtimes}" \
-DLLVM_INSTALL_UTILS=ON

start-group "ninja"

Expand Down