[AMDGPU] Add sema check for global_atomic_fadd_v2f16 builtin #158145
+49
−3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -verify %s | ||
|
There was a problem hiding this comment. Can you verify we have test coverage using OpenCL plus one of the C/C++/HIP variants |
||
|
|
||
| // Test semantic analysis for AMDGCN atomic fadd v2f16 builtins | ||
| // These tests ensure proper type checking for the builtin arguments | ||
|
|
||
| typedef _Float16 v2f16 __attribute__((ext_vector_type(2))); | ||
| typedef float v2f32 __attribute__((ext_vector_type(2))); | ||
| typedef _Float16 v4f16 __attribute__((ext_vector_type(4))); | ||
|
|
||
|
There was a problem hiding this comment. Can you also test some of the cases with the type embedded in a structure like was crashing There was a problem hiding this comment. I think the type was from hip though. How do I add a type from hip_fp16 to a clang test? Do I need to put the test in one of the hip/opencl folders? Thanks! |
||
| void test_global_atomic_fadd_v2f16_negative() { | ||
| v2f16 val; | ||
| v2f32 val_f32; | ||
| v4f16 val_v4f16; | ||
| _Float16 __attribute__((ext_vector_type(2))) __attribute__((address_space(1))) *ptr_v2f16; | ||
|
|
||
| __builtin_amdgcn_global_atomic_fadd_v2f16(ptr_v2f16, val_f32); // expected-error{{passing 'v2f32'}} | ||
| __builtin_amdgcn_global_atomic_fadd_v2f16(ptr_v2f16, val_v4f16); // expected-error{{passing 'v4f16'}} | ||
| __builtin_amdgcn_global_atomic_fadd_v2f16(ptr_v2f16); // expected-error{{too few arguments to function call}} | ||
| __builtin_amdgcn_global_atomic_fadd_v2f16(ptr_v2f16, val, val); // expected-error{{too many arguments to function call}} | ||
| } | ||
|
|
||
| void test_flat_atomic_fadd_v2f16_negative() { | ||
| v2f16 val; | ||
| v2f32 val_f32; | ||
| v4f16 val_v4f16; | ||
| _Float16 __attribute__((ext_vector_type(2))) __attribute__((address_space(0))) *ptr_v2f16; | ||
|
|
||
| // Same error patterns for flat atomic | ||
| __builtin_amdgcn_flat_atomic_fadd_v2f16(ptr_v2f16, val_f32); // expected-error{{passing 'v2f32'}} | ||
| __builtin_amdgcn_flat_atomic_fadd_v2f16(ptr_v2f16, val_v4f16); // expected-error{{passing 'v4f16'}} | ||
| __builtin_amdgcn_flat_atomic_fadd_v2f16(ptr_v2f16); // expected-error{{too few arguments to function call}} | ||
| __builtin_amdgcn_flat_atomic_fadd_v2f16(ptr_v2f16, val, val); // expected-error{{too many arguments to function call}} | ||
| } | ||
|
|
||
| void test_ds_atomic_fadd_v2f16_negative() { | ||
| v2f16 val; | ||
| v2f32 val_f32; | ||
| v4f16 val_v4f16; | ||
| _Float16 __attribute__((ext_vector_type(2))) __attribute__((address_space(3))) *ptr_v2f16; | ||
|
|
||
| // Same error patterns for ds atomic | ||
| __builtin_amdgcn_ds_atomic_fadd_v2f16(ptr_v2f16, val_f32); // expected-error{{passing 'v2f32'}} | ||
| __builtin_amdgcn_ds_atomic_fadd_v2f16(ptr_v2f16, val_v4f16); // expected-error{{passing 'v4f16'}} | ||
| __builtin_amdgcn_ds_atomic_fadd_v2f16(ptr_v2f16); // expected-error{{too few arguments to function call}} | ||
| __builtin_amdgcn_ds_atomic_fadd_v2f16(ptr_v2f16, val, val); // expected-error{{too many arguments to function call}} | ||
| } | ||
|
There was a problem hiding this comment. bf16 vector cases and f32 cases are also marked with t, and probably broken in the same way |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also make sure to test this with all of these similar intrinsics, the "t"s are all suspicious (I'm guessing if it was for anything, it was hacking around the address space of the pointer across the languages)