Skip to content

[Utils] Compare true file locations instead of string paths #158160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

[Utils] Compare true file locations instead of string paths #158160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions llvm/utils/lit/lit/DiffUpdater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import shutil
import os
import shlex
import pathlib

"""
This file provides the `diff_test_updater` function, which is invoked on failed RUN lines when lit is executed with --update-tests.
Expand Down Expand Up @@ -76,14 +77,12 @@ def get_target_dir(commands, test_path):

@staticmethod
def create(path, commands, test_path, target_dir):
filename = path.replace(target_dir, "")
if filename.startswith(os.sep):
filename = filename[len(os.sep) :]
path = pathlib.Path(path)
with open(test_path, "r") as f:
lines = f.readlines()
for i, l in enumerate(lines):
p = SplitFileTarget._get_split_line_path(l)
if p == filename:
if p and path.samefile(os.path.join(target_dir, p)):
idx = i
break
else:
Expand Down