Skip to content

[mlir][NFC] Correct pattern names to match the behaviors. #158177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

[mlir][NFC] Correct pattern names to match the behaviors. #158177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mlir/lib/Dialect/Tensor/Transforms/ReshapePatterns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ struct BubbleUpExpandThroughParallelCollapse
/// Note - this pattern could be extended to be a swap pattern between
/// `tensor.expand_shape` and `tensor.extract_slice`, but is currently
/// implemented only as a bubble up pattern for `tensor.extract_slice`.
struct BubbleUpExpandShapeThroughExtractSlice
struct BubbleUpExtractSliceThroughExpandShape
: public OpRewritePattern<tensor::ExtractSliceOp> {
using OpRewritePattern<tensor::ExtractSliceOp>::OpRewritePattern;

Expand Down Expand Up @@ -427,7 +427,7 @@ struct BubbleUpExpandShapeThroughExtractSlice
/// to tensor<15xf32>
/// ```
/// But this is not the intended purpose of the transformation.
struct BubbleUpCollapseShapeThroughExtractSlice
struct BubbleUpExtractSliceThroughCollapseShape
: public OpRewritePattern<tensor::ExtractSliceOp> {
using OpRewritePattern<tensor::ExtractSliceOp>::OpRewritePattern;

Expand Down Expand Up @@ -735,6 +735,6 @@ void mlir::tensor::populateBubbleUpExpandShapePatterns(

void mlir::tensor::populateBubbleUpExtractSliceOpPatterns(
RewritePatternSet &patterns) {
patterns.add<BubbleUpExpandShapeThroughExtractSlice,
BubbleUpCollapseShapeThroughExtractSlice>(patterns.getContext());
patterns.add<BubbleUpExtractSliceThroughExpandShape,
BubbleUpExtractSliceThroughCollapseShape>(patterns.getContext());
}