Skip to content

[Mips] Fix inst sc disassemble assert when configured -mattr=+ptr64 #158253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

[Mips] Fix inst sc disassemble assert when configured -mattr=+ptr64 #158253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Target/Mips/Disassembler/MipsDisassembler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,7 +1468,7 @@ static DecodeStatus DecodeMem(MCInst &Inst, unsigned Insn, uint64_t Address,
Reg = getReg(Decoder, Mips::GPR32RegClassID, Reg);
Base = getReg(Decoder, Mips::GPR32RegClassID, Base);

if (Inst.getOpcode() == Mips::SC ||
if (Inst.getOpcode() == Mips::SC || Inst.getOpcode() == Mips::SC64 ||
Inst.getOpcode() == Mips::SCD)
Inst.addOperand(MCOperand::createReg(Reg));

Expand Down
3 changes: 3 additions & 0 deletions llvm/test/MC/Disassembler/Mips/mips64/sc-ptr64.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# RUN: llvm-mc -triple=mips64el-unknown-linux -disassemble -mattr=+ptr64 -mcpu=mips3 %s | FileCheck %s

0xd8 0x49 0x6f 0xe2 # CHECK: sc $15, 18904($19)
Loading