Skip to content

[lldb] Fixed UB in CPlusPlusLanguage plug-in #158304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

[lldb] Fixed UB in CPlusPlusLanguage plug-in #158304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,14 +190,16 @@ static bool IsTrivialBasename(const llvm::StringRef &basename) {
if (basename.size() <= idx)
return false; // Empty string or "~"

if (!std::isalpha(basename[idx]) && basename[idx] != '_')
if (!std::isalpha(static_cast<unsigned char>(basename[idx])) &&
basename[idx] != '_')
return false; // First character (after removing the possible '~'') isn't in
// [A-Za-z_]

// Read all characters matching [A-Za-z_0-9]
++idx;
while (idx < basename.size()) {
if (!std::isalnum(basename[idx]) && basename[idx] != '_')
if (!std::isalnum(static_cast<unsigned char>(basename[idx])) &&
basename[idx] != '_')
break;
++idx;
}
Expand Down
6 changes: 4 additions & 2 deletions lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ using namespace lldb_private::formatters;
static void consumeInlineNamespace(llvm::StringRef &name) {
// Delete past an inline namespace, if any: __[a-zA-Z0-9_]+::
auto scratch = name;
if (scratch.consume_front("__") && std::isalnum(scratch[0])) {
scratch = scratch.drop_while([](char c) { return std::isalnum(c); });
if (scratch.consume_front("__") &&
std::isalnum(static_cast<unsigned char>(scratch[0]))) {
scratch = scratch.drop_while(
[](char c) { return std::isalnum(static_cast<unsigned char>(c)); });
if (scratch.consume_front("::")) {
// Successfully consumed a namespace.
name = scratch;
Expand Down
Loading