Skip to content

[lit] Split Linux specific ulimit tests #158390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2025
Merged

[lit] Split Linux specific ulimit tests #158390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93fd2e4
[lit] Split Linux specific ulimit tests
boomanaiden154 Sep 13, 2025
bb6ae63
feedback
boomanaiden154 Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions llvm/utils/lit/tests/Inputs/shtest-ulimit-linux/lit.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import lit.formats

config.name = "shtest-ulimit"
config.suffixes = [".txt"]
config.test_format = lit.formats.ShTest(execute_external=False)
config.test_source_root = None
config.test_exec_root = None
config.substitutions.append(("%{python}", '"%s"' % (sys.executable)))
4 changes: 4 additions & 0 deletions llvm/utils/lit/tests/Inputs/shtest-ulimit-linux/ulimit_okay.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# RUN: ulimit -v 1048576
# RUN: %{python} %S/../shtest-ulimit/print_limits.py
# Fail the test so that we can assert on the output.
# RUN: not echo return
1 change: 0 additions & 1 deletion llvm/utils/lit/tests/Inputs/shtest-ulimit/ulimit_okay.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# RUN: ulimit -v 1048576
# RUN: ulimit -n 50
# RUN: %{python} %S/print_limits.py
# Fail the test so that we can assert on the output.
Expand Down
15 changes: 7 additions & 8 deletions llvm/utils/lit/tests/shtest-ulimit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,8 @@
# ulimit does not work on non-POSIX platforms.
# UNSUPPORTED: system-windows

# TODO(boomanaiden154): The test fails on some non-Linux POSIX
# platforms (like MacOS) due to the underlying system not supporting
# ulimit -v. This test needs to be carved up so we keep full test
# coverage on Linux and as much as possible on other platforms.
# REQUIRES: system-linux

# RUN: not %{lit} -a -v %{inputs}/shtest-ulimit | FileCheck %s
# RUN: %if system-linux %{ not %{lit} -a -v %{inputs}/shtest-ulimit-linux | FileCheck %s --check-prefix CHECK-LINUX %}

# CHECK: -- Testing: 2 tests{{.*}}

Expand All @@ -18,7 +13,11 @@
# CHECK: 'ulimit' requires two arguments

# CHECK-LABEL: FAIL: shtest-ulimit :: ulimit_okay.txt ({{[^)]*}})
# CHECK: ulimit -v 1048576
# CHECK: ulimit -n 50
# CHECK: RLIMIT_AS=1073741824
# CHECK: RLIMIT_NOFILE=50

# CHECK-LINUX: -- Testing: 1 tests{{.*}}

# CHECK-LINUX-LABEL: FAIL: shtest-ulimit :: ulimit_okay.txt ({{[^)]*}})
# CHECK-LINUX: ulimit -v 1048576
# CHECK-LINUX: RLIMIT_AS=1073741824