-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[TableGen, CodeGen, CHERI] Add support for the cPTR wildcard value type. #158426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -367,6 +367,10 @@ def aarch64mfp8 : ValueType<8, 253>; // 8-bit value in FPR (AArch64) | |
def c64 : VTCheriCapability<64, 254>; // 64-bit CHERI capability value | ||
def c128 : VTCheriCapability<128, 255>; // 128-bit CHERI capability value | ||
|
||
// Pseudo valuetype mapped to the current CHERI capability pointer size. | ||
// Should only be used in TableGen. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm maybe this regression is caused by this not being inside the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @abadams I wonder if moving this into the let block just below fixes your problem? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doing that drops it back to 0.5 MB, yes. Though the class probably still shouldn't be on the stack. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @resistor are you planning to submit a PR to fix the regression or should I? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm traveling for the next few days. I can do it when I have time, but you might have time sooner than I do. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay I'll submit it shortly |
||
def cPTR : VTAny<503>; | ||
|
||
let isNormalValueType = false in { | ||
def token : ValueType<0, 504>; // TokenTy | ||
def MetadataVT : ValueType<0, 505> { // Metadata | ||
|
Uh oh!
There was an error while loading. Please reload this page.