Skip to content

[GlobalISel] add KnownBits tracking for G_UMULH and G_SMULH #158445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[GlobalISel] add KnownBits tracking for G_UMULH and G_SMULH #158445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3574456
[GlobalISel] add KnownBits tracking for G_UMULH and G_SMULH
r41k0u Sep 13, 2025
468f4e4
[GlobalISel] add GISelValueTracking tests for G_UMULH and G_SMULH
r41k0u Sep 14, 2025
2752649
[GlobalISel] update CodeGen/AArch64/pr58431.ll to agree with KnownBit…
r41k0u Sep 14, 2025
25c37de
[GlobalISel] Update AMDGPU tests after G_UMULH/G_SMULH knownbits change
r41k0u Sep 19, 2025
7020b78
[GlobalISel] Early exit if the first arg is fully unknown in G_UMULH/…
r41k0u Sep 19, 2025
003acad
[GlobalISel] clang-format
r41k0u Sep 19, 2025
5263f16
[GlobalISel] Update AMDGPU tests
r41k0u Sep 20, 2025
b9ac7ff
[GlobalISel] Revert "[GlobalISel] Update AMDGPU tests"
r41k0u Sep 21, 2025
31fa2f6
[GlobalIsel] Revert "[GlobalISel] Early exit if the first arg is full…
r41k0u Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions llvm/lib/CodeGen/GlobalISel/GISelValueTracking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,22 @@ void GISelValueTracking::computeKnownBitsImpl(Register R, KnownBits &Known,
Known = KnownBits::mul(Known, Known2);
break;
}
case TargetOpcode::G_UMULH: {
computeKnownBitsImpl(MI.getOperand(2).getReg(), Known, DemandedElts,
Depth + 1);
computeKnownBitsImpl(MI.getOperand(1).getReg(), Known2, DemandedElts,
Depth + 1);
Known = KnownBits::mulhu(Known, Known2);
break;
}
case TargetOpcode::G_SMULH: {
computeKnownBitsImpl(MI.getOperand(2).getReg(), Known, DemandedElts,
Depth + 1);
computeKnownBitsImpl(MI.getOperand(1).getReg(), Known2, DemandedElts,
Depth + 1);
Known = KnownBits::mulhs(Known, Known2);
break;
}
case TargetOpcode::G_SELECT: {
computeKnownBitsMin(MI.getOperand(2).getReg(), MI.getOperand(3).getReg(),
Known, DemandedElts, Depth + 1);
Expand Down
137 changes: 137 additions & 0 deletions llvm/test/CodeGen/AArch64/GlobalISel/knownbits-smulh.mir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
# NOTE: Assertions have been autogenerated by utils/update_givaluetracking_test_checks.py UTC_ARGS: --version 6
# RUN: llc -mtriple=aarch64 -passes='print<gisel-value-tracking>' -filetype=null %s 2>&1 | FileCheck %s

---
name: Cst
body: |
bb.0:
; CHECK-LABEL: name: @Cst
; CHECK-NEXT: %0:_ KnownBits:00010011 SignBits:3
; CHECK-NEXT: %1:_ KnownBits:11100000 SignBits:3
; CHECK-NEXT: %2:_ KnownBits:11111101 SignBits:6
%0:_(s8) = G_CONSTANT i8 19
%1:_(s8) = G_CONSTANT i8 224
%2:_(s8) = G_SMULH %0, %1
...
---
name: CstZero
body: |
bb.0:
; CHECK-LABEL: name: @CstZero
; CHECK-NEXT: %0:_ KnownBits:11111111 SignBits:8
; CHECK-NEXT: %1:_ KnownBits:00000000 SignBits:8
; CHECK-NEXT: %2:_ KnownBits:00000000 SignBits:8
%0:_(s8) = G_CONSTANT i8 255
%1:_(s8) = G_CONSTANT i8 0
%2:_(s8) = G_SMULH %0, %1
...
---
name: ScalarVar
body: |
bb.0:
; CHECK-LABEL: name: @ScalarVar
; CHECK-NEXT: %0:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %1:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %2:_ KnownBits:???????? SignBits:1
%0:_(s8) = COPY $b0
%1:_(s8) = COPY $b1
%2:_(s8) = G_SMULH %0, %1
...
---
name: ScalarZero
body: |
bb.0:
; CHECK-LABEL: name: @ScalarZero
; CHECK-NEXT: %0:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %1:_ KnownBits:00000000 SignBits:8
; CHECK-NEXT: %2:_ KnownBits:00000000 SignBits:8
%0:_(s8) = COPY $b0
%1:_(s8) = G_CONSTANT i8 0
%2:_(s8) = G_SMULH %0, %1
...
---
name: ScalarVarAbs
body: |
bb.0:
; CHECK-LABEL: name: @ScalarVarAbs
; CHECK-NEXT: %0:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %1:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %2:_ KnownBits:???????????????? SignBits:9
; CHECK-NEXT: %3:_ KnownBits:0000000000000001 SignBits:15
; CHECK-NEXT: %4:_ KnownBits:???????????????? SignBits:1
%0:_(s8) = COPY $b0
%1:_(s8) = G_ABS %0
%2:_(s16) = G_SEXT %1
%3:_(s16) = G_CONSTANT i16 1
%4:_(s16) = G_SMULH %2, %3
...
---
name: SplatVecCst
body: |
bb.0:
; CHECK-LABEL: name: @SplatVecCst
; CHECK-NEXT: %0:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %1:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %2:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %3:_ KnownBits:00000000 SignBits:8
%0:_(s8) = G_CONSTANT i8 250
%1:_(<vscale x 16 x s8>) = G_SPLAT_VECTOR %0(s8)
%2:_(<vscale x 16 x s8>) = G_SPLAT_VECTOR %0(s8)
%3:_(<vscale x 16 x s8>) = G_SMULH %1, %2
...
---
name: SplatVecPartScalar
body: |
bb.0:
; CHECK-LABEL: name: @SplatVecPartScalar
; CHECK-NEXT: %0:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %1:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %2:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %3:_ KnownBits:00001111 SignBits:4
; CHECK-NEXT: %4:_ KnownBits:0000???? SignBits:4
; CHECK-NEXT: %5:_ KnownBits:0000???? SignBits:4
; CHECK-NEXT: %6:_ KnownBits:???????? SignBits:1
%0:_(s8) = G_CONSTANT i8 250
%1:_(<vscale x 16 x s8>) = G_SPLAT_VECTOR %0(s8)
%2:_(s8) = G_IMPLICIT_DEF
%3:_(s8) = G_CONSTANT i8 15
%4:_(s8) = G_AND %2, %3
%5:_(<vscale x 16 x s8>) = G_SPLAT_VECTOR %4(s8)
%6:_(<vscale x 16 x s8>) = G_SMULH %1, %5
...
---
name: VecCst
body: |
bb.0:
; CHECK-LABEL: name: @VecCst
; CHECK-NEXT: %0:_ KnownBits:00011001 SignBits:3
; CHECK-NEXT: %1:_ KnownBits:11100001 SignBits:3
; CHECK-NEXT: %2:_ KnownBits:?????001 SignBits:3
; CHECK-NEXT: %3:_ KnownBits:?????001 SignBits:3
; CHECK-NEXT: %4:_ KnownBits:???????? SignBits:1
%0:_(s8) = G_CONSTANT i8 25
%1:_(s8) = G_CONSTANT i8 225
%2:_(<2 x s8>) = G_BUILD_VECTOR %0:_(s8), %1:_(s8)
%3:_(<2 x s8>) = G_BUILD_VECTOR %0:_(s8), %1:_(s8)
%4:_(<2 x s8>) = G_SMULH %2, %3
...
---
name: VecPartScalar
body: |
bb.0:
; CHECK-LABEL: name: @VecPartScalar
; CHECK-NEXT: %0:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %1:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %2:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %3:_ KnownBits:00001111 SignBits:4
; CHECK-NEXT: %4:_ KnownBits:0000???? SignBits:4
; CHECK-NEXT: %5:_ KnownBits:0000???? SignBits:4
; CHECK-NEXT: %6:_ KnownBits:???????? SignBits:1
%0:_(s8) = G_CONSTANT i8 250
%1:_(<2 x s8>) = G_BUILD_VECTOR %0:_(s8), %0:_(s8)
%2:_(s8) = G_IMPLICIT_DEF
%3:_(s8) = G_CONSTANT i8 15
%4:_(s8) = G_AND %2, %3
%5:_(<2 x s8>) = G_BUILD_VECTOR %4:_(s8), %4:_(s8)
%6:_(<2 x s8>) = G_SMULH %1, %5
...
137 changes: 137 additions & 0 deletions llvm/test/CodeGen/AArch64/GlobalISel/knownbits-umulh.mir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
# NOTE: Assertions have been autogenerated by utils/update_givaluetracking_test_checks.py UTC_ARGS: --version 6
# RUN: llc -mtriple=aarch64 -passes='print<gisel-value-tracking>' -filetype=null %s 2>&1 | FileCheck %s

---
name: Cst
body: |
bb.0:
; CHECK-LABEL: name: @Cst
; CHECK-NEXT: %0:_ KnownBits:00010011 SignBits:3
; CHECK-NEXT: %1:_ KnownBits:11100000 SignBits:3
; CHECK-NEXT: %2:_ KnownBits:00010000 SignBits:3
%0:_(s8) = G_CONSTANT i8 19
%1:_(s8) = G_CONSTANT i8 224
%2:_(s8) = G_UMULH %0, %1
...
---
name: CstZero
body: |
bb.0:
; CHECK-LABEL: name: @CstZero
; CHECK-NEXT: %0:_ KnownBits:11111111 SignBits:8
; CHECK-NEXT: %1:_ KnownBits:00000000 SignBits:8
; CHECK-NEXT: %2:_ KnownBits:00000000 SignBits:8
%0:_(s8) = G_CONSTANT i8 255
%1:_(s8) = G_CONSTANT i8 0
%2:_(s8) = G_UMULH %0, %1
...
---
name: ScalarVar
body: |
bb.0:
; CHECK-LABEL: name: @ScalarVar
; CHECK-NEXT: %0:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %1:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %2:_ KnownBits:???????? SignBits:1
%0:_(s8) = COPY $b0
%1:_(s8) = COPY $b1
%2:_(s8) = G_UMULH %0, %1
...
---
name: ScalarZero
body: |
bb.0:
; CHECK-LABEL: name: @ScalarZero
; CHECK-NEXT: %0:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %1:_ KnownBits:00000000 SignBits:8
; CHECK-NEXT: %2:_ KnownBits:00000000 SignBits:8
%0:_(s8) = COPY $b0
%1:_(s8) = G_CONSTANT i8 0
%2:_(s8) = G_UMULH %0, %1
...
---
name: ScalarVarAbs
body: |
bb.0:
; CHECK-LABEL: name: @ScalarVarAbs
; CHECK-NEXT: %0:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %1:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %2:_ KnownBits:???????????????? SignBits:9
; CHECK-NEXT: %3:_ KnownBits:0000000000000001 SignBits:15
; CHECK-NEXT: %4:_ KnownBits:0000000000000000 SignBits:16
%0:_(s8) = COPY $b0
%1:_(s8) = G_ABS %0
%2:_(s16) = G_SEXT %1
%3:_(s16) = G_CONSTANT i16 1
%4:_(s16) = G_UMULH %2, %3
...
---
name: SplatVecCst
body: |
bb.0:
; CHECK-LABEL: name: @SplatVecCst
; CHECK-NEXT: %0:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %1:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %2:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %3:_ KnownBits:11110100 SignBits:4
%0:_(s8) = G_CONSTANT i8 250
%1:_(<vscale x 16 x s8>) = G_SPLAT_VECTOR %0(s8)
%2:_(<vscale x 16 x s8>) = G_SPLAT_VECTOR %0(s8)
%3:_(<vscale x 16 x s8>) = G_UMULH %1, %2
...
---
name: SplatVecPartScalar
body: |
bb.0:
; CHECK-LABEL: name: @SplatVecPartScalar
; CHECK-NEXT: %0:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %1:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %2:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %3:_ KnownBits:00001111 SignBits:4
; CHECK-NEXT: %4:_ KnownBits:0000???? SignBits:4
; CHECK-NEXT: %5:_ KnownBits:0000???? SignBits:4
; CHECK-NEXT: %6:_ KnownBits:0000???? SignBits:4
%0:_(s8) = G_CONSTANT i8 250
%1:_(<vscale x 16 x s8>) = G_SPLAT_VECTOR %0(s8)
%2:_(s8) = G_IMPLICIT_DEF
%3:_(s8) = G_CONSTANT i8 15
%4:_(s8) = G_AND %2, %3
%5:_(<vscale x 16 x s8>) = G_SPLAT_VECTOR %4(s8)
%6:_(<vscale x 16 x s8>) = G_UMULH %1, %5
...
---
name: VecCst
body: |
bb.0:
; CHECK-LABEL: name: @VecCst
; CHECK-NEXT: %0:_ KnownBits:00011001 SignBits:3
; CHECK-NEXT: %1:_ KnownBits:11100001 SignBits:3
; CHECK-NEXT: %2:_ KnownBits:?????001 SignBits:3
; CHECK-NEXT: %3:_ KnownBits:?????001 SignBits:3
; CHECK-NEXT: %4:_ KnownBits:???????? SignBits:1
%0:_(s8) = G_CONSTANT i8 25
%1:_(s8) = G_CONSTANT i8 225
%2:_(<2 x s8>) = G_BUILD_VECTOR %0:_(s8), %1:_(s8)
%3:_(<2 x s8>) = G_BUILD_VECTOR %0:_(s8), %1:_(s8)
%4:_(<2 x s8>) = G_UMULH %2, %3
...
---
name: VecPartScalar
body: |
bb.0:
; CHECK-LABEL: name: @VecPartScalar
; CHECK-NEXT: %0:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %1:_ KnownBits:11111010 SignBits:5
; CHECK-NEXT: %2:_ KnownBits:???????? SignBits:1
; CHECK-NEXT: %3:_ KnownBits:00001111 SignBits:4
; CHECK-NEXT: %4:_ KnownBits:0000???? SignBits:4
; CHECK-NEXT: %5:_ KnownBits:0000???? SignBits:4
; CHECK-NEXT: %6:_ KnownBits:0000???? SignBits:4
%0:_(s8) = G_CONSTANT i8 250
%1:_(<2 x s8>) = G_BUILD_VECTOR %0:_(s8), %0:_(s8)
%2:_(s8) = G_IMPLICIT_DEF
%3:_(s8) = G_CONSTANT i8 15
%4:_(s8) = G_AND %2, %3
%5:_(<2 x s8>) = G_BUILD_VECTOR %4:_(s8), %4:_(s8)
%6:_(<2 x s8>) = G_UMULH %1, %5
...
2 changes: 1 addition & 1 deletion llvm/test/CodeGen/AArch64/pr58431.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ define i32 @f(i64 %0) {
; CHECK-NEXT: mov w10, #10 // =0xa
; CHECK-NEXT: eor x8, x8, #0x8000000000000003
; CHECK-NEXT: umulh x8, x9, x8
; CHECK-NEXT: msub x0, x8, x10, x9
; CHECK-NEXT: umsubl x0, w8, w10, x9
; CHECK-NEXT: // kill: def $w0 killed $w0 killed $x0
; CHECK-NEXT: ret
%2 = trunc i64 %0 to i32
Expand Down
Loading