[flang][runtime] Use dlsym to access char** environ on FreeBSD #158477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
arrowd
force-pushed
the
flang-runtime-environ
branch
from
9832e87 to
ddb43ca
Compare
Contributor
Author
|
Ping. |
Contributor
Author
|
@llvm/pr-subscribers-flang-driver @llvm/pr-subscribers-flang-codegen Hopefully this is a correct way to get reviewers for a PR. |
Meinersbur
reviewed
Oct 29, 2025
arrowd
force-pushed
the
flang-runtime-environ
branch
from
ddb43ca to
f17c23b
Compare
klausler
reviewed
Oct 29, 2025
arrowd
force-pushed
the
flang-runtime-environ
branch
from
f17c23b to
fa847a8
Compare
klausler
approved these changes
Oct 29, 2025
Meinersbur
approved these changes
Oct 30, 2025
Contributor
Author
|
Can we get this in? I'm hoping for this change to be present in the 22 release. |
Member
|
We reviewers usually assume that the author will land the PR themselves after it is approved. If you do not have permission to do that, would you like me to land this PR? |
Contributor
Author
|
Ah, I see. Yes, I do not have rights to merge this, so please land it for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.