Skip to content

[Sema] Fix missing warnings for unused args with invalid printf specs. #158514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Sema] Fix missing warnings for unused args with invalid printf specs. #158514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef99801
[Sema] Fix missing warnings for unused args with invalid printf specs.
lakreite Sep 14, 2025
0fafb04
Merge branch 'main' into fix-format-unused-args-invalid-spec
lakreite Sep 14, 2025
16f6dd3
Merge branch 'main' into fix-format-unused-args-invalid-spec
lakreite Sep 14, 2025
fa8e5a1
Merge branch 'main' into fix-format-unused-args-invalid-spec
lakreite Sep 15, 2025
3e9d70f
Merge branch 'main' into fix-format-unused-args-invalid-spec
lakreite Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/AST/PrintfFormatString.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ bool clang::analyze_format_string::ParsePrintfString(FormatStringHandler &H,
// Did a fail-stop error of any kind occur when parsing the specifier?
// If so, don't do any more processing.
if (FSR.shouldStop())
return true;
return false;
// Did we exhaust the string or encounter an error that
// we can recover from?
if (!FSR.hasValue())
Expand Down
28 changes: 14 additions & 14 deletions clang/test/Sema/format-strings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,9 @@ void check_invalid_specifier(FILE* fp, char *buf)

void check_null_char_string(char* b)
{
printf("\0this is bogus%d",1); // expected-warning {{string contains '\0'}}
snprintf(b,10,"%%%%%d\0%d",1,2); // expected-warning {{string contains '\0'}}
printf("%\0d",1); // expected-warning {{string contains '\0'}}
printf("\0this is bogus%d",1); // expected-warning {{string contains '\0'}} expected-warning {{data argument not used by format string}}
snprintf(b,10,"%%%%%d\0%d",1,2); // expected-warning {{string contains '\0'}} expected-warning {{data argument not used by format string}}
printf("%\0d",1); // expected-warning {{string contains '\0'}} expected-warning {{data argument not used by format string}}
}

void check_empty_format_string(char* buf, ...)
Expand Down Expand Up @@ -297,7 +297,7 @@ void test10(int x, float f, int i, long long lli) {
printf("%W%d\n", x, x); // expected-warning{{invalid conversion specifier 'W'}} expected-warning {{data argument not used by format string}}
printf("%"); // expected-warning{{incomplete format specifier}}
printf("%.d", x); // no-warning
printf("%.", x); // expected-warning{{incomplete format specifier}}
printf("%.", x); // expected-warning{{incomplete format specifier}} expected-warning {{data argument not used by format string}}
printf("%f", 4); // expected-warning{{format specifies type 'double' but the argument has type 'int'}}
printf("%qd", lli); // no-warning
printf("%qd", x); // expected-warning{{format specifies type 'long long' but the argument has type 'int'}}
Expand Down Expand Up @@ -390,8 +390,8 @@ void test_unicode_conversions(wchar_t *s) {
// This is an IEEE extension (IEEE Std 1003.1).
// FIXME: This is probably not portable everywhere.
void test_positional_arguments(void) {
printf("%0$", (int)2); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
printf("%1$*0$d", (int) 2); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
printf("%0$", (int)2); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}} expected-warning{{data argument not used by format string}}
printf("%1$*0$d", (int) 2); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}} expected-warning{{data argument not used by format string}}
printf("%1$d", (int) 2); // no-warning
printf("%1$d", (int) 2, 2); // expected-warning{{data argument not used by format string}}
printf("%1$d%1$f", (int) 2); // expected-warning{{format specifies type 'double' but the argument has type 'int'}}
Expand Down Expand Up @@ -595,16 +595,16 @@ void pr9751(void) {
printf("%y", 5); // expected-warning{{invalid conversion specifier 'y'}}

const char kFormat5[] = "%."; // expected-note{{format string is defined here}}
printf(kFormat5, 5); // expected-warning{{incomplete format specifier}}
printf("%.", 5); // expected-warning{{incomplete format specifier}}
printf(kFormat5, 5); // expected-warning{{incomplete format specifier}} expected-warning{{data argument not used by format string}}
printf("%.", 5); // expected-warning{{incomplete format specifier}} expected-warning{{data argument not used by format string}}

const char kFormat6[] = "%s"; // expected-note{{format string is defined here}}
printf(kFormat6, 5); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
printf("%s", 5); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}

const char kFormat7[] = "%0$"; // expected-note{{format string is defined here}}
printf(kFormat7, 5); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
printf("%0$", 5); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
printf(kFormat7, 5); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}} expected-warning{{data argument not used by format string}}
printf("%0$", 5); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}} expected-warning{{data argument not used by format string}}

const char kFormat8[] = "%1$d %d"; // expected-note{{format string is defined here}}
printf(kFormat8, 4, 4); // expected-warning{{cannot mix positional and non-positional arguments in format string}}
Expand All @@ -615,8 +615,8 @@ void pr9751(void) {
printf("", 4, 4); // expected-warning{{format string is empty}}

const char kFormat10[] = "\0%d"; // expected-note{{format string is defined here}}
printf(kFormat10, 4); // expected-warning{{format string contains '\0' within the string body}}
printf("\0%d", 4); // expected-warning{{format string contains '\0' within the string body}}
printf(kFormat10, 4); // expected-warning{{format string contains '\0' within the string body}} expected-warning{{data argument not used by format string}}
printf("\0%d", 4); // expected-warning{{format string contains '\0' within the string body}} expected-warning{{data argument not used by format string}}

const char kFormat11[] = "%*d"; // expected-note{{format string is defined here}}
printf(kFormat11); // expected-warning{{'*' specified field width is missing a matching 'int' argument}}
Expand Down Expand Up @@ -720,8 +720,8 @@ extern void test14_bar(const char *, const char *, ...)
__attribute__((__format__(__printf__, 1, 3)));

void test14_zed(int *p) {
test14_foo("%", "%d", p); // expected-warning{{incomplete format specifier}}
test14_bar("%", "%d", p); // expected-warning{{incomplete format specifier}}
test14_foo("%", "%d", p); // expected-warning{{incomplete format specifier}} expected-warning{{data argument not used by format string}}
test14_bar("%", "%d", p); // expected-warning{{incomplete format specifier}} expected-warning{{data argument not used by format string}}
}

#if !defined(__ANDROID__) && !defined(__Fuchsia__)
Expand Down
10 changes: 5 additions & 5 deletions clang/test/SemaObjC/format-strings-objc.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,15 +274,15 @@ void testUnicode(void) {

// Test Objective-C modifier flags.
void testObjCModifierFlags(void) {
NSLog(@"%[]@", @"Foo"); // expected-warning {{missing object format flag}}
NSLog(@"%[", @"Foo"); // expected-warning {{incomplete format specifier}}
NSLog(@"%[tt", @"Foo"); // expected-warning {{incomplete format specifier}}
NSLog(@"%[]@", @"Foo"); // expected-warning {{missing object format flag}} expected-warning{{data argument not used by format string}}
NSLog(@"%[", @"Foo"); // expected-warning {{incomplete format specifier}} expected-warning{{data argument not used by format string}}
NSLog(@"%[tt", @"Foo"); // expected-warning {{incomplete format specifier}} expected-warning{{data argument not used by format string}}
NSLog(@"%[tt]@", @"Foo"); // no-warning
NSLog(@"%[tt]@ %s", @"Foo", "hello"); // no-warning
NSLog(@"%s %[tt]@", "hello", @"Foo"); // no-warning
NSLog(@"%[blark]@", @"Foo"); // expected-warning {{'blark' is not a valid object format flag}}
NSLog(@"%[blark]@", @"Foo"); // expected-warning {{'blark' is not a valid object format flag}} expected-warning{{data argument not used by format string}}
NSLog(@"%2$[tt]@ %1$[tt]@", @"Foo", @"Bar"); // no-warning
NSLog(@"%2$[tt]@ %1$[tt]s", @"Foo", @"Bar"); // expected-warning {{object format flags cannot be used with 's' conversion specifier}}
NSLog(@"%2$[tt]@ %1$[tt]s", @"Foo", @"Bar"); // expected-warning {{object format flags cannot be used with 's' conversion specifier}} expected-warning{{data argument not used by format string}}
}

@interface RD23622446_Tester: NSObject
Expand Down
12 changes: 6 additions & 6 deletions clang/test/SemaOpenCL/printf-format-strings.cl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,18 +96,18 @@ kernel void format_v4f32(float4 arg)

kernel void format_only_v(int arg)
{
printf("%v", arg); // expected-warning {{incomplete format specifier}}
printf("%v", arg); // expected-warning {{incomplete format specifier}} expected-warning{{data argument not used by format string}}
}

kernel void format_missing_num(int arg)
{
printf("%v4", arg); // expected-warning {{incomplete format specifier}}
printf("%v4", arg); // expected-warning {{incomplete format specifier}} expected-warning{{data argument not used by format string}}
}

kernel void format_not_num(int arg)
{
printf("%vNd", arg); // expected-warning {{incomplete format specifier}}
printf("%v*d", arg); // expected-warning {{incomplete format specifier}}
printf("%vNd", arg); // expected-warning {{incomplete format specifier}} expected-warning{{data argument not used by format string}}
printf("%v*d", arg); // expected-warning {{incomplete format specifier}} expected-warning{{data argument not used by format string}}
}

kernel void format_v16i32(int16 arg)
Expand All @@ -127,7 +127,7 @@ kernel void format_v4i32_wrong_num_elts_2_to_4(int2 arg)

kernel void format_missing_num_elts_format(int4 arg)
{
printf("%vd\n", arg); // expected-warning {{incomplete format specifier}}
printf("%vd\n", arg); // expected-warning {{incomplete format specifier}} expected-warning{{data argument not used by format string}}
}

kernel void format_v4f32_scalar(float arg)
Expand All @@ -142,7 +142,7 @@ kernel void format_v4f32_wrong_num_elts(float2 arg)

kernel void format_missing_num_elts(float4 arg)
{
printf("%vf\n", arg); // expected-warning {{incomplete format specifier}}
printf("%vf\n", arg); // expected-warning {{incomplete format specifier}} expected-warning{{data argument not used by format string}}
}

kernel void vector_precision_modifier_v4i32_to_v4f32(int4 arg)
Expand Down
Loading