Skip to content

[lldb][LoongArch] Preserve temporary symbols starting with .L in lldb symbol table #158551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[lldb][LoongArch] Preserve temporary symbols starting with .L in lldb symbol table #158551

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6679a6
[lldb][LoongArch] Preserve temporary symbols starting with `.L` in ll…
zhaoqi5 Sep 15, 2025
a091f36
address comment
zhaoqi5 Sep 15, 2025
5548303
clang format
zhaoqi5 Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2119,8 +2119,12 @@ ObjectFileELF::ParseSymbols(Symtab *symtab, user_id_t start_id,
// generated local labels used for internal purposes (e.g. debugging,
// optimization) and are not relevant for symbol resolution or external
// linkage.
if (llvm::StringRef(symbol_name).starts_with(".L"))
continue;
// LoongArch64 always uses symbols for relocations, so temporary symbols
// starting with ".L" should be preserved.
if (arch.GetMachine() != llvm::Triple::loongarch64) {
if (llvm::StringRef(symbol_name).starts_with(".L"))
continue;
}
// No need to add non-section symbols that have no names
if (symbol.getType() != STT_SECTION &&
(symbol_name == nullptr || symbol_name[0] == '\0'))
Expand Down
Loading