Skip to content

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Sep 15, 2025

Amends #158284 and fixes the failure on lldb-remote-linux-win from #158284 (comment). That builder is configured with the DIA SDK but builds for Linux, so the debug information will be DWARF, not PDB.

@llvmbot
Copy link
Member

llvmbot commented Sep 15, 2025

@llvm/pr-subscribers-lldb

Author: nerix (Nerixyz)

Changes

Amends #158284 and fixes the failure on lldb-remote-linux-win from #158284 (comment). That builder is configured with the DIA SDK but builds for Linux, so the debug information will be DWARF, not PDB.


Full diff: https://github.com/llvm/llvm-project/pull/158559.diff

1 Files Affected:

  • (modified) lldb/test/Shell/SymbolFile/PDB/native-setting.cpp (+1-1)
diff --git a/lldb/test/Shell/SymbolFile/PDB/native-setting.cpp b/lldb/test/Shell/SymbolFile/PDB/native-setting.cpp
index edf7508b88f17..a3077252f08f1 100644
--- a/lldb/test/Shell/SymbolFile/PDB/native-setting.cpp
+++ b/lldb/test/Shell/SymbolFile/PDB/native-setting.cpp
@@ -1,4 +1,4 @@
-// REQUIRES: diasdk
+// REQUIRES: diasdk, target-windows
 
 // Test plugin.symbol-file.pdb.reader setting
 // RUN: %build -o %t.exe -- %s

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nerixyz Nerixyz merged commit 4de9bee into llvm:main Sep 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants