Skip to content

Conversation

sarnex
Copy link
Member

@sarnex sarnex commented Sep 15, 2025

See here, need to add -- to filename parsing on Mac because the path starts with /U which clang-cl treats as the flag /U.

@sarnex sarnex marked this pull request as ready for review September 15, 2025 16:29
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 15, 2025
@sarnex sarnex requested review from rnk and dyung September 15, 2025 16:29
@llvmbot
Copy link
Member

llvmbot commented Sep 15, 2025

@llvm/pr-subscribers-clang

Author: Nick Sarnie (sarnex)

Changes

See here, need to add -- to filename parsing on Mac because the path starts with /U which clang-cl treats as the flag /U.


Full diff: https://github.com/llvm/llvm-project/pull/158677.diff

1 Files Affected:

  • (modified) clang/test/Headers/arm-acle-no-direct-include.c (+1-1)
diff --git a/clang/test/Headers/arm-acle-no-direct-include.c b/clang/test/Headers/arm-acle-no-direct-include.c
index b69549d92e4b0..d6a01a7417f0c 100644
--- a/clang/test/Headers/arm-acle-no-direct-include.c
+++ b/clang/test/Headers/arm-acle-no-direct-include.c
@@ -1,4 +1,4 @@
-// RUN: %clang_cl --target=aarch64-windows-msvc -Xclang -verify /E -U__STDC_HOSTED__ -Wno-builtin-macro-redefined %s 2>&1 | FileCheck %s
+// RUN: %clang_cl --target=aarch64-windows-msvc -Xclang -verify /E -U__STDC_HOSTED__ -Wno-builtin-macro-redefined -- %s 2>&1 | FileCheck %s
 
 // expected-no-diagnostics
 

Copy link
Collaborator

@dyung dyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sarnex sarnex enabled auto-merge (squash) September 15, 2025 16:32
@sarnex sarnex disabled auto-merge September 15, 2025 16:32
@sarnex sarnex merged commit c193d71 into llvm:main Sep 15, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants