[mlir][spirv] Update spirv validation for module.mlir

[IgWod-IMG]

This is to check that the new spirv-val behaviour works correctly. Subsequent PRs will add validation to other target tests. This requires the most recent SPIRV-Tools to work; for existing build directories using bundled SPIR-V tools, running SPIRVTools-update cmake target should update them accordingly.

The minimum required SPIRV-Tools version is commit 14d42009a9435c34ea55b26cc8d92240c428a052, merged in KhronosGroup/SPIRV-Tools#6292

[llvmbot]

@llvm/pr-subscribers-mlir-spirv

Author: Igor Wodiany (IgWod-IMG)

Changes

This is to check that the new spirv-val behaviour works correctly. Subsequent PRs will add validation to other target tests. This requires the most recent SPIRV-Tools to work (for existing build directories that use bundled SPIR-V tools SPIRVTools-update cmake target should do the trick).

---

Full diff: https://github.com/llvm/llvm-project/pull/158678.diff

1 Files Affected:

• (modified) mlir/test/Target/SPIRV/module.mlir (+1-1)

diff --git a/mlir/test/Target/SPIRV/module.mlir b/mlir/test/Target/SPIRV/module.mlir
index d4000dfa53810..7e52e549b5266 100644
--- a/mlir/test/Target/SPIRV/module.mlir
+++ b/mlir/test/Target/SPIRV/module.mlir
@@ -4,7 +4,7 @@
 // RUN: %if spirv-tools %{ rm -rf %t %}
 // RUN: %if spirv-tools %{ mkdir %t %}
 // RUN: %if spirv-tools %{ mlir-translate --no-implicit-module --serialize-spirv --split-input-file --spirv-save-validation-files-with-prefix=%t/module %s %}
-// RUN: %if spirv-tools %{ ls %t/module*.spv | xargs -I{} spirv-val {} %}
+// RUN: %if spirv-tools %{ spirv-val %t %}
 
 // CHECK:      spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> {
 // CHECK-NEXT:   spirv.func @foo() "Inline" {

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Igor Wodiany (IgWod-IMG)

Changes

This is to check that the new spirv-val behaviour works correctly. Subsequent PRs will add validation to other target tests. This requires the most recent SPIRV-Tools to work (for existing build directories that use bundled SPIR-V tools SPIRVTools-update cmake target should do the trick).

---

Full diff: https://github.com/llvm/llvm-project/pull/158678.diff

1 Files Affected:

• (modified) mlir/test/Target/SPIRV/module.mlir (+1-1)

diff --git a/mlir/test/Target/SPIRV/module.mlir b/mlir/test/Target/SPIRV/module.mlir
index d4000dfa53810..7e52e549b5266 100644
--- a/mlir/test/Target/SPIRV/module.mlir
+++ b/mlir/test/Target/SPIRV/module.mlir
@@ -4,7 +4,7 @@
 // RUN: %if spirv-tools %{ rm -rf %t %}
 // RUN: %if spirv-tools %{ mkdir %t %}
 // RUN: %if spirv-tools %{ mlir-translate --no-implicit-module --serialize-spirv --split-input-file --spirv-save-validation-files-with-prefix=%t/module %s %}
-// RUN: %if spirv-tools %{ ls %t/module*.spv | xargs -I{} spirv-val {} %}
+// RUN: %if spirv-tools %{ spirv-val %t %}
 
 // CHECK:      spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> {
 // CHECK-NEXT:   spirv.func @foo() "Inline" {

[kuhar]

Nice! Can you link to your spirv-val PR in the PR description so that downstream users know what is the minimum spirv-tools commit required to run this test?