Skip to content

[mlir][arith][NFC] Minor Revisions to Comments #158757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2025
Merged

[mlir][arith][NFC] Minor Revisions to Comments #158757

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be57899
Minor comment fixes
akhilgoe Sep 15, 2025
7b68d7d
Merge branch 'main' into arith_comments
akhilgoe Sep 15, 2025
43e620d
Update comment
akhilgoe Sep 16, 2025
540eb64
Merge branch 'main' into arith_comments
akhilgoe Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/lib/Dialect/Arith/IR/ArithCanonicalization.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ def TruncIShrSIToTrunciShrUI :
[(TruncationMatchesShiftAmount $x, $tr, $c0)]>;

//===----------------------------------------------------------------------===//
// TruncIOp
// TruncFOp
//===----------------------------------------------------------------------===//

// truncf(sitofp(x)) -> sitofp(x) if default rounding mode.
Expand Down
2 changes: 1 addition & 1 deletion mlir/lib/Dialect/Arith/IR/ArithOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2723,7 +2723,7 @@ TypedAttr mlir::arith::getIdentityValueAttr(AtomicRMWKind kind, Type resultType,
return nullptr;
}

/// Return the identity numeric value associated to the give op.
/// Return the identity numeric value associated to the given op.
std::optional<TypedAttr> mlir::arith::getNeutralElement(Operation *op) {
std::optional<AtomicRMWKind> maybeKind =
llvm::TypeSwitch<Operation *, std::optional<AtomicRMWKind>>(op)
Expand Down