[OFFLOAD] Add plugin with support for Intel oneAPI Level Zero #158900
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| # Create the library and add the default arguments. | ||
| add_target_library(omptarget.rtl.level_zero LEVEL_ZERO) | ||
|
|
||
| set(LEVEL_ZERO_SRC_FILES | ||
| src/L0Context.cpp | ||
| src/L0Device.cpp | ||
| src/L0Kernel.cpp | ||
| src/L0Memory.cpp | ||
| src/L0Program.cpp | ||
| src/L0Plugin.cpp | ||
| src/L0Program.cpp | ||
| src/L0Options.cpp | ||
| ) | ||
|
|
||
| target_sources(omptarget.rtl.level_zero PRIVATE | ||
| ${LEVEL_ZERO_SRC_FILES} | ||
| ) | ||
|
|
||
| target_include_directories(omptarget.rtl.level_zero PRIVATE | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/include | ||
| ) | ||
|
|
||
| target_include_directories(omptarget.rtl.level_zero PRIVATE | ||
| ${LIBOMPTARGET_INCLUDE_DIR} | ||
| ${LIBOMPTARGET_DEP_LEVEL_ZERO_INCLUDE_DIR} | ||
| ${LIBOMPTARGET_LLVM_INCLUDE_DIRS} | ||
| ${LIBOMPTARGET_OMP_HEADER_DIR} | ||
| ) | ||
|
|
||
| cmake_path(GET LIBOMPTARGET_DEP_LEVEL_ZERO_LIBRARY FILENAME LEVEL_ZERO_LIBRARY_NAME) | ||
| if (EXISTS ${LIBOMPTARGET_DEP_LEVEL_ZERO_LIBRARY} AND NOT "level_zero" IN_LIST LIBOMPTARGET_DLOPEN_PLUGINS) | ||
| message(STATUS "Building Level Zero NG plugin linked against level_zero library") | ||
| if(UNIX) | ||
| target_link_libraries(omptarget.rtl.level_zero PRIVATE | ||
| ${LIBOMPTARGET_DEP_LEVEL_ZERO_LIBRARY}) | ||
| elseif(WIN32) | ||
| # Full path to the Level Zero library is recognized as a linker option, so we | ||
| # separate directory and file name | ||
| cmake_path(GET LIBOMPTARGET_DEP_LEVEL_ZERO_LIBRARY PARENT_PATH LEVEL_ZERO_LIBRARY_PATH) | ||
| target_link_libraries(omptarget.rtl.level_zero PRIVATE ${LEVEL_ZERO_LIBRARY_NAME} | ||
| ${LIBOMP_LIB_FILE}) | ||
| target_link_directories(omptarget.rtl.level_zero PRIVATE ${LEVEL_ZERO_LIBRARY_PATH}) | ||
| else() | ||
| message(FATAL_ERROR "Missing platform support") | ||
| endif() | ||
| else() | ||
| message(STATUS "Building Level Zero NG plugin for dlopened level_zero") | ||
| if(WIN32) | ||
| cmake_path(REPLACE_EXTENSION LEVEL_ZERO_LIBRARY_NAME dll) | ||
| endif() | ||
|
Comment on lines
+48
to
+50
Contributor
There was a problem hiding this comment. Does the L0 library name change? Why can't we just do
Contributor
Author
There was a problem hiding this comment. The extension is different. Yes, we could do it in the source, but why would we want to do the required string manipulation at runtime when can be done statically here? |
||
| target_compile_definitions(omptarget.rtl.level_zero PRIVATE | ||
| LEVEL_ZERO_LIBRARY="${LEVEL_ZERO_LIBRARY_NAME}") | ||
| target_sources(omptarget.rtl.level_zero PRIVATE src/L0DynWrapper.cpp) | ||
| endif() | ||
|
|
||
| option(LIBOMPTARGET_FORCE_LEVELZERO_TESTS "Build Level Zero libomptarget tests" OFF) | ||
| if (LIBOMPTARGET_FOUND_INTELGPU_GPU OR LIBOMPTARGET_FORCE_LEVELZERO_TESTS) | ||
| # Report to the parent scope that we are building a plugin for intelgpu | ||
| set(LIBOMPTARGET_SYSTEM_TARGETS | ||
| "${LIBOMPTARGET_SYSTEM_TARGETS} spirv64-intel" PARENT_SCOPE) | ||
| list(APPEND LIBOMPTARGET_TESTED_PLUGINS "omptarget.rtl.level_zero") | ||
| set(LIBOMPTARGET_TESTED_PLUGINS "${LIBOMPTARGET_TESTED_PLUGINS}" PARENT_SCOPE) | ||
| else() | ||
| message(STATUS "Not generating Level Zero tests, no supported devices detected." | ||
| " Use 'LIBOMPTARGET_FORCE_INTELGPU_TESTS' to override.") | ||
| endif() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| //===--- Level Zero Target RTL Implementation -----------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Async Queue wrapper for Level Zero | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef OPENMP_LIBOMPTARGET_PLUGINS_NEXTGEN_LEVEL_ZERO_ASYNCQUEUE_H | ||
| #define OPENMP_LIBOMPTARGET_PLUGINS_NEXTGEN_LEVEL_ZERO_ASYNCQUEUE_H | ||
|
|
||
| #include <tuple> | ||
|
|
||
| #include "L0Memory.h" | ||
|
|
||
| namespace llvm { | ||
| namespace omp { | ||
| namespace target { | ||
| namespace plugin { | ||
|
|
||
| /// Abstract queue that supports asynchronous command submission | ||
| struct AsyncQueueTy { | ||
| /// List of events attached to submitted commands | ||
| llvm::SmallVector<ze_event_handle_t> WaitEvents; | ||
| /// Pending staging buffer to host copies | ||
| llvm::SmallVector<std::tuple<void *, void *, size_t>> H2MList; | ||
| /// Pending USM memory copy commands that must wait for kernel completion | ||
| llvm::SmallVector<std::tuple<const void *, void *, size_t>> USM2MList; | ||
| /// Kernel event not signaled | ||
| ze_event_handle_t KernelEvent = nullptr; | ||
| /// Is this queue being used currently | ||
| bool InUse = false; | ||
| /// Clear data | ||
| void reset() { | ||
| WaitEvents.clear(); | ||
| H2MList.clear(); | ||
| USM2MList.clear(); | ||
| KernelEvent = nullptr; | ||
| } | ||
| }; | ||
|
|
||
| typedef ObjPool<AsyncQueueTy> AsyncQueuePoolTy; | ||
|
|
||
| } // namespace plugin | ||
| } // namespace target | ||
| } // namespace omp | ||
| } // namespace llvm | ||
|
|
||
| #endif // OPENMP_LIBOMPTARGET_PLUGINS_NEXTGEN_LEVEL_ZERO_ASYNCQUEUE_H |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to do this check when we create the list rather than removing it later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other plugins are treated in the same way right now (e.g., 3 lines above). They are in the "candidate" list and if some condition is not met they're removed.
I don't disagree with your statement about do it earlier but we should be consistent, so maybe something to do subsequently?