Skip to content

Conversation

@kimgr
Copy link
Contributor

@kimgr kimgr commented Sep 16, 2025

According to 249167a, users are expected to include Type.h, which acts as a facade header for TypeBase.h.

Add an IWYU export pragma to help IWYU reason about the relationship.

According to 249167a, users are
expected to include Type.h, which acts as a facade header for
TypeBase.h.

Add an IWYU export pragma to help IWYU reason about the relationship.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Sep 16, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 16, 2025

@llvm/pr-subscribers-clang

Author: Kim Gräsman (kimgr)

Changes

According to 249167a, users are expected to include Type.h, which acts as a facade header for TypeBase.h.

Add an IWYU export pragma to help IWYU reason about the relationship.


Full diff: https://github.com/llvm/llvm-project/pull/159154.diff

1 Files Affected:

  • (modified) clang/include/clang/AST/Type.h (+1-1)
diff --git a/clang/include/clang/AST/Type.h b/clang/include/clang/AST/Type.h
index 48575c1b19395..df106d5b12c8d 100644
--- a/clang/include/clang/AST/Type.h
+++ b/clang/include/clang/AST/Type.h
@@ -19,7 +19,7 @@
 
 #include "clang/AST/Decl.h"
 #include "clang/AST/DeclCXX.h"
-#include "clang/AST/TypeBase.h"
+#include "clang/AST/TypeBase.h" // IWYU pragma: export
 
 namespace clang {
 

@kimgr
Copy link
Contributor Author

kimgr commented Sep 16, 2025

@mizvekov Does this make sense to you? Hoping I interpreted your intent correctly.

Copy link
Contributor

@mizvekov mizvekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the intent. Thanks!

@kimgr
Copy link
Contributor Author

kimgr commented Sep 16, 2025

@mizvekov Thanks! Could you merge it for me? I don't have commit access.

@mizvekov mizvekov merged commit 081fe1d into llvm:main Sep 16, 2025
12 checks passed
@kimgr
Copy link
Contributor Author

kimgr commented Sep 16, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants