Skip to content

Fix comment from https://github.com/llvm/llvm-project/pull/158719 #159157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

Fix comment from https://github.com/llvm/llvm-project/pull/158719 #159157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a01e29f
Fix comment from https://github.com/llvm/llvm-project/pull/158719
hjyamauchi Sep 16, 2025
8341e38
Merge branch 'main' into emptyenv
hjyamauchi Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions llvm/lib/Support/Windows/Program.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,7 @@ static bool Execute(ProcessInfo &PI, StringRef Program,
llvm::append_range(EnvBlock, EnvString);
EnvBlock.push_back(0);
}
// If an empty environment (*Env is size zero), we need to
// terminate with two nulls.
// Empty environments need to be terminated with two nulls.
if (Env->size() == 0)
EnvBlock.push_back(0);
EnvBlock.push_back(0);
Expand Down