Skip to content

Conversation

dzhidzhoev
Copy link
Member

@dzhidzhoev dzhidzhoev commented Sep 17, 2025

Duplication of function and class name in the comment is discouraged in https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments.

I'll be merging this immediately, as this change was requested in #159104 (comment), but I'm open to post-commit review.

@dzhidzhoev dzhidzhoev merged commit 47bd167 into llvm:main Sep 17, 2025
8 of 10 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Sep 17, 2025

LLVM Buildbot has detected a new failure on builder ppc64le-mlir-rhel-clang running on ppc64le-mlir-rhel-test while building llvm at step 6 "test-build-check-mlir-build-only-check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/129/builds/29675

Here is the relevant piece of the build log for the reference
Step 6 (test-build-check-mlir-build-only-check-mlir) failure: 1200 seconds without output running [b'ninja', b'check-mlir'], attempting to kill
...
PASS: MLIR-Unit :: Interfaces/./MLIRInterfacesTests/12/22 (3488 of 3499)
PASS: MLIR :: mlir-runner/utils.mlir (3489 of 3499)
PASS: MLIR-Unit :: Interfaces/./MLIRInterfacesTests/11/22 (3490 of 3499)
PASS: MLIR :: mlir-runner/verify-entry-point.mlir (3491 of 3499)
PASS: MLIR :: mlir-tblgen/cpp-class-comments.td (3492 of 3499)
PASS: MLIR :: mlir-runner/simple.mlir (3493 of 3499)
PASS: MLIR :: mlir-reduce/dce-test.mlir (3494 of 3499)
PASS: MLIR :: mlir-tblgen/op-error.td (3495 of 3499)
PASS: MLIR :: mlir-tblgen/llvm-intrinsics.td (3496 of 3499)
PASS: MLIR :: Pass/pipeline-options-parsing.mlir (3497 of 3499)
command timed out: 1200 seconds without output running [b'ninja', b'check-mlir'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1842.764965

@dwblaikie dwblaikie added the skip-precommit-approval PR for CI feedback, not intended for review label Sep 17, 2025
@dwblaikie
Copy link
Collaborator

(If you're creating a PR just for presubmit checks, not intending it to be reviewed/approved-before-commit, please be sure to include the skip-precommit-approval tag on it so it doesn't look like a case of "I sent this for review and then committed it without the required review")

Thanks for the cleanup!

@dzhidzhoev
Copy link
Member Author

Ah, thank you for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-precommit-approval PR for CI feedback, not intended for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants