[DTLTO] Remove XFAIL for llvm-driver #159413
Open
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTLTO is still incompatible with llvm-driver, but the test started passing after llvm#159151.
llvmbot
added
clang
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Petr Hosek (petrhosek) ChangesDTLTO is still incompatible with llvm-driver, but the test started passing after #159151. Full diff: https://github.com/llvm/llvm-project/pull/159413.diff 1 Files Affected:
diff --git a/clang/test/Driver/DTLTO/dtlto.c b/clang/test/Driver/DTLTO/dtlto.c
index 66299c890e4b3..ebb9fc288e91e 100644
--- a/clang/test/Driver/DTLTO/dtlto.c
+++ b/clang/test/Driver/DTLTO/dtlto.c
@@ -1,8 +1,5 @@
// REQUIRES: lld
-/// https://github.com/llvm/llvm-project/issues/159125.
-// XFAIL: llvm-driver
-
/// Check DTLTO options are forwarded to the linker.
/// Check that options are forwarded as expected with --thinlto-distributor=.
|
|
@petrhosek. Thanks for putting this up and apologies for the disruption to you. There was another failure due to the regex's being too greedy. Can you please review PR #159418 in preference to this. Thanks. |
bd1976bris
requested changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DTLTO is still incompatible with llvm-driver, but the test started passing after #159151.