Skip to content

Conversation

@tbaederr
Copy link
Contributor

@tbaederr tbaederr commented Sep 18, 2025

There are a few places in clang where we pass a list of diagnostic notes to the evaluate* functions, which so some extra work when that list is passed (e.g. attaching call stacks to the diagnostics). We then sometimes later don't use the notes list at all, or we only use it to check if any notes have been emitted.

This patch adds two new flags to EvalStatus to check if any diagnostics have been emitted (right now one of the would suffice though, I guess), which replaces the Notes.empty() use case.

It also changes the signature of EvaluateAsInitializer to pass an EvalStatus object instead, so we don't have to pass a notes list but can still examine the resulting flags.

@tbaederr
Copy link
Contributor Author

@tbaederr tbaederr closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant