Skip to content

[ADT] Use C++17 fold expression in PointerSumType (NFC) #159560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

[ADT] Use C++17 fold expression in PointerSumType (NFC) #159560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions llvm/include/llvm/ADT/PointerSumType.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,19 +239,9 @@ struct PointerSumTypeHelper : MemberTs... {
TagMask = ~PointerMask
};

// Finally we need a recursive template to do static checks of each
// member.
template <typename MemberT, typename... InnerMemberTs>
struct Checker : Checker<InnerMemberTs...> {
static_assert(MemberT::Tag < (1 << NumTagBits),
"This discriminant value requires too many bits!");
};
template <typename MemberT> struct Checker<MemberT> : std::true_type {
static_assert(MemberT::Tag < (1 << NumTagBits),
"This discriminant value requires too many bits!");
};
static_assert(Checker<MemberTs...>::value,
"Each member must pass the checker.");
// Finally, statically check each member.
static_assert(((MemberTs::Tag < (1 << NumTagBits)) && ...),
"A discriminant value requires too many bits!");
};

} // end namespace detail
Expand Down