Skip to content

[clang][Sema] Reject negative tuple sizes #159579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[clang][Sema] Reject negative tuple sizes #159579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/Sema/SemaDeclCXX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,7 @@ static IsTupleLike isTupleLike(Sema &S, SourceLocation Loc, QualType T,
return IsTupleLike::Error;

E = S.VerifyIntegerConstantExpression(E.get(), &Size, Diagnoser);
if (E.isInvalid())
if (E.isInvalid() || Size.isNegative())
return IsTupleLike::Error;

return IsTupleLike::TupleLike;
Expand Down
9 changes: 9 additions & 0 deletions clang/test/SemaCXX/builtin-structured-binding-size.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,3 +229,12 @@ static_assert(__is_same_as(tag_of_t<S1>, int));
static_assert(__is_same_as(tag_of_t<int>, int)); // error
// expected-error@-1 {{constraints not satisfied for alias template 'tag_of_t' [with T = int]}}
// expected-note@#tag-of-constr {{because substituted constraint expression is ill-formed: type 'int' cannot be decomposed}}

struct Neg {
int a;
};
template <> struct std::tuple_size<Neg> {
static constexpr int value = -1;
};

int e = __builtin_structured_binding_size(Neg); // expected-error {{type 'Neg' cannot be decomposed}}