Skip to content

[Offload] Implement 'olIsValidBinary' in offload and clean up #159658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

[Offload] Implement 'olIsValidBinary' in offload and clean up #159658

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd5a0ad
[Offload] Implement 'olIsValidBinary' in offload and clean up
jhuber6 Sep 18, 2025
915c4ac
More test
jhuber6 Sep 19, 2025
a241dd9
remove incorrect comment
jhuber6 Sep 19, 2025
1726cfd
better test
jhuber6 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions offload/unittests/OffloadAPI/program/olIsValidBinary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,13 @@ TEST_P(olIsValidBinaryTest, Success) {
ASSERT_SUCCESS(olIsValidBinary(Device, DeviceBin->getBufferStart(),
DeviceBin->getBufferSize(), &IsValid));
ASSERT_TRUE(IsValid);

ASSERT_SUCCESS(
olIsValidBinary(Device, DeviceBin->getBufferStart(), 0, &IsValid));
ASSERT_FALSE(IsValid);

ASSERT_ERROR(
OL_ERRC_INVALID_NULL_POINTER,
olIsValidBinary(Device, nullptr, DeviceBin->getBufferSize(), &IsValid));
ASSERT_FALSE(IsValid);
}
Loading