[MC] Update '-mcpu=native' test to be Linux only. #159838
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm::sys::getHostCPUName() and llvm::sys::getHostCPUFeatures() appear to need special cases for _WIN32 on X86 (similar to the existing _WIN32 on ARM special cases) to restrict what CPUs and Features are available with that OS. For now, limit this test to Linux systems only, as this test does not check very much being that it is sensitve to the Host machine. Originally llvm#159414.
|
@gkistanova, does this seem reasonable to you? I am not a Windows expert by any means. I suspect that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::sys::getHostCPUName() and llvm::sys::getHostCPUFeatures() appear to need special cases for _WIN32 on X86 (similar to the existing _WIN32 on ARM special cases) to restrict what CPUs and Features are available with that OS.
For now, limit this test to Linux systems only, as this test does not check very much being that it is sensitive to the Host machine.
Originally #159414.