[clang-tidy] add readability-redundant-parentheses #159911

HerrCai0907 · 2025-09-20T08:19:09Z

This check wants to detect a common happened case that forgetting to
remove parenthese during modifying code.

This check wants to detect a common happened case that forgetting to remove parenthese during modifying code.

llvmbot · 2025-09-20T08:19:42Z

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clang-tidy

Author: Congcong Cai (HerrCai0907)

Changes

This check wants to detect a common happened case that forgetting to
remove parenthese during modifying code.

Full diff: https://github.com/llvm/llvm-project/pull/159911.diff

8 Files Affected:

(modified) clang-tools-extra/clang-tidy/readability/CMakeLists.txt (+1)
(modified) clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp (+3)
(added) clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp (+54)
(added) clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h (+31)
(modified) clang-tools-extra/docs/ReleaseNotes.rst (+5)
(modified) clang-tools-extra/docs/clang-tidy/checks/list.rst (+1)
(added) clang-tools-extra/docs/clang-tidy/checks/readability/redundant-parentheses.rst (+29)
(added) clang-tools-extra/test/clang-tidy/checkers/readability/redundant-parentheses.cpp (+58)

diff --git a/clang-tools-extra/clang-tidy/readability/CMakeLists.txt b/clang-tools-extra/clang-tidy/readability/CMakeLists.txt
index 4b4c49d3b17d1..0d0641c4b22bf 100644
--- a/clang-tools-extra/clang-tidy/readability/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/readability/CMakeLists.txt
@@ -44,6 +44,7 @@ add_clang_library(clangTidyReadabilityModule STATIC
   RedundantDeclarationCheck.cpp
   RedundantFunctionPtrDereferenceCheck.cpp
   RedundantMemberInitCheck.cpp
+  RedundantParenthesesCheck.cpp
   RedundantPreprocessorCheck.cpp
   RedundantSmartptrGetCheck.cpp
   RedundantStringCStrCheck.cpp
diff --git a/clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp b/clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
index d01882dfc9daa..fcfac05b000e4 100644
--- a/clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
+++ b/clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
@@ -47,6 +47,7 @@
 #include "RedundantFunctionPtrDereferenceCheck.h"
 #include "RedundantInlineSpecifierCheck.h"
 #include "RedundantMemberInitCheck.h"
+#include "RedundantParenthesesCheck.h"
 #include "RedundantPreprocessorCheck.h"
 #include "RedundantSmartptrGetCheck.h"
 #include "RedundantStringCStrCheck.h"
@@ -138,6 +139,8 @@ class ReadabilityModule : public ClangTidyModule {
         "readability-redundant-function-ptr-dereference");
     CheckFactories.registerCheck<RedundantMemberInitCheck>(
         "readability-redundant-member-init");
+    CheckFactories.registerCheck<RedundantParenthesesCheck>(
+        "readability-redundant-parentheses");
     CheckFactories.registerCheck<RedundantPreprocessorCheck>(
         "readability-redundant-preprocessor");
     CheckFactories.registerCheck<ReferenceToConstructedTemporaryCheck>(
diff --git a/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp b/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp
new file mode 100644
index 0000000000000..6517f68216787
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp
@@ -0,0 +1,54 @@
+
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "RedundantParenthesesCheck.h"
+#include "clang/AST/Expr.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/ASTMatchers/ASTMatchers.h"
+#include "clang/ASTMatchers/ASTMatchersMacros.h"
+#include <cassert>
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::readability {
+
+namespace {
+
+AST_MATCHER_P(ParenExpr, subExpr, ast_matchers::internal::Matcher<Expr>,
+              InnerMatcher) {
+  return InnerMatcher.matches(*Node.getSubExpr(), Finder, Builder);
+}
+
+} // namespace
+
+void RedundantParenthesesCheck::registerMatchers(MatchFinder *Finder) {
+  Finder->addMatcher(
+      parenExpr(subExpr(anyOf(parenExpr(), integerLiteral(), floatLiteral(),
+                              characterLiteral(), cxxBoolLiteral(),
+                              stringLiteral(), declRefExpr())),
+                unless(
+                    // sizeof(...) is common used.
+                    hasParent(unaryExprOrTypeTraitExpr())))
+          .bind("dup"),
+      this);
+}
+
+void RedundantParenthesesCheck::check(const MatchFinder::MatchResult &Result) {
+  const auto *PE = Result.Nodes.getNodeAs<ParenExpr>("dup");
+  assert(PE);
+  const Expr *E = PE->getSubExpr();
+  if (PE->getLParen().isMacroID() || PE->getRParen().isMacroID() ||
+      E->getBeginLoc().isMacroID() || E->getEndLoc().isMacroID())
+    return;
+  diag(PE->getBeginLoc(), "redundant parentheses around expression")
+      << FixItHint::CreateRemoval(PE->getLParen())
+      << FixItHint::CreateRemoval(PE->getRParen());
+}
+
+} // namespace clang::tidy::readability
diff --git a/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h b/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h
new file mode 100644
index 0000000000000..8806fb391ba26
--- /dev/null
+++ b/clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h
@@ -0,0 +1,31 @@
+
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_REDUNDANTPARENTHESESCHECK_H
+#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_REDUNDANTPARENTHESESCHECK_H
+
+#include "../ClangTidyCheck.h"
+
+namespace clang::tidy::readability {
+
+/// Detect redundant parentheses.
+///
+/// For the user-facing documentation see:
+/// http://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-parentheses.html
+class RedundantParenthesesCheck : public ClangTidyCheck {
+public:
+  RedundantParenthesesCheck(StringRef Name, ClangTidyContext *Context)
+      : ClangTidyCheck(Name, Context) {}
+  void registerMatchers(ast_matchers::MatchFinder *Finder) override;
+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
+};
+
+} // namespace clang::tidy::readability
+
+#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_READABILITY_REDUNDANTPARENTHESESCHECK_H
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index a4652a7a54858..1dbacaf061b73 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -203,6 +203,11 @@ New checks
   Finds virtual function overrides with different visibility than the function
   in the base class.
 
+- New :doc:`readability-redundant-parentheses
+  <clang-tidy/checks/readability/redundant-parentheses>` check.
+
+  Detect redundant parentheses.
+
 New check aliases
 ^^^^^^^^^^^^^^^^^
 
diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst
index e06849c419389..51d968895044c 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -404,6 +404,7 @@ Clang-Tidy Checks
    :doc:`readability-redundant-function-ptr-dereference <readability/redundant-function-ptr-dereference>`, "Yes"
    :doc:`readability-redundant-inline-specifier <readability/redundant-inline-specifier>`, "Yes"
    :doc:`readability-redundant-member-init <readability/redundant-member-init>`, "Yes"
+   :doc:`readability-redundant-parentheses <readability/redundant-parentheses>`, "Yes"
    :doc:`readability-redundant-preprocessor <readability/redundant-preprocessor>`,
    :doc:`readability-redundant-smartptr-get <readability/redundant-smartptr-get>`, "Yes"
    :doc:`readability-redundant-string-cstr <readability/redundant-string-cstr>`, "Yes"
diff --git a/clang-tools-extra/docs/clang-tidy/checks/readability/redundant-parentheses.rst b/clang-tools-extra/docs/clang-tidy/checks/readability/redundant-parentheses.rst
new file mode 100644
index 0000000000000..09f9113b89cbd
--- /dev/null
+++ b/clang-tools-extra/docs/clang-tidy/checks/readability/redundant-parentheses.rst
@@ -0,0 +1,29 @@
+.. title:: clang-tidy - readability-redundant-parentheses
+
+readability-redundant-parentheses
+=================================
+
+Detect redundant parentheses.
+
+When modifying the code, one often forgets to remove the corresponding parentheses.
+This results in overly lengthy code. When the expression is complex, finding
+the matching parentheses becomes particularly difficult.
+
+Example
+-------
+
+.. code-block:: c++
+
+  (1);
+  ((a + 2)) * 3;
+  (a);
+  ("aaa");
+
+Currently this check does not take into account the precedence of operations.
+Even if the expression within the parentheses has a higher priority than that
+outside the parentheses, in other words, removing the parentheses will not
+affect the semantic.
+
+.. code-block:: c++
+
+  int a = (1 * 2) + 3; // no warning
diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-parentheses.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-parentheses.cpp
new file mode 100644
index 0000000000000..017f22ec75721
--- /dev/null
+++ b/clang-tools-extra/test/clang-tidy/checkers/readability/redundant-parentheses.cpp
@@ -0,0 +1,58 @@
+// RUN: %check_clang_tidy %s readability-redundant-parentheses %t
+
+void parenExpr() {
+  1 + 1;
+  (1 + 1);
+  ((1 + 1));
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    (1 + 1);
+  (((1 + 1)));
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-MESSAGES: :[[@LINE-2]]:4: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    (1 + 1);
+  ((((1 + 1))));
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-MESSAGES: :[[@LINE-2]]:4: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-MESSAGES: :[[@LINE-3]]:5: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    (1 + 1);
+}
+
+#define EXP (1 + 1)
+#define PAREN(e) (e)
+void parenExprWithMacro() {
+  EXP; // 1
+  (EXP); // 2
+  ((EXP)); // 3
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    (EXP); // 3
+  PAREN((1));
+}
+
+void constant() {
+  (1);
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    1;
+  (1.0);
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    1.0;
+  (true);
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    true;
+  (',');
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    ',';
+  ("v4");
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    "v4";
+}
+
+void declRefExpr(int a) {
+  (a);
+  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: redundant parentheses around expression [readability-redundant-parentheses]
+  // CHECK-FIXES:    a;
+}
+
+void exceptions() {
+  sizeof(1);
+  alignof(2);
+}

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h

localspook · 2025-09-20T16:45:42Z

Clang-format has an option like this already. Unlike clang-format, we have full semantic information, so this check has the potential to be more reliable, but I’m concerned about duplicating functionality. What do you think?

vbvictor · 2025-09-20T17:07:53Z

Clang-format has an option like this already. Unlike clang-format, we have full semantic information, so this check has the potential to be more reliable, but I’m concerned about duplicating functionality. What do you think?

I don't see a problem in duplicating functionality given clang-tidy would have fever false-positives.
We already have https://clang.llvm.org/docs/ClangFormatStyleOptions.html#insertbraces vs https://clang.llvm.org/extra/clang-tidy/checks/readability/braces-around-statements.html

Generally speaking, if clang-format option has warning Setting this option to true could lead to incorrect code formatting due to clang-format’s lack of complete semantic information, I doubt it will be ever enforced in CI but same clang-tidy check could be in CI.

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp

clang-tools-extra/test/clang-tidy/checkers/readability/redundant-parentheses.cpp

vbvictor · 2025-09-21T20:32:44Z

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h

+  RedundantParenthesesCheck(StringRef Name, ClangTidyContext *Context)
+      : ClangTidyCheck(Name, Context) {}
+  void registerMatchers(ast_matchers::MatchFinder *Finder) override;
+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;


Could we set isLanguageVersionSupported to CPlusPlus || C99 otherwise the check may run on ObjC, which may have different semantics I guess..

I wonder, could we make the default to CPlusPlus || C99 instead of true here:

llvm-project/clang-tools-extra/clang-tidy/ClangTidyCheck.h

Lines 68 to 70 in c12f08f

virtual bool isLanguageVersionSupported(const LangOptions &LangOpts) const {

return true;

}

I wonder, could we make the default to CPlusPlus || C99 instead of true here

It needs RFC IMO. I have never written OC so I don't know the ecosystem of OC. Is clang-tidy a common used tools in OC's world?

I wonder, could we make the default to CPlusPlus || C99 instead of true here

I have never written OC so I don't know the ecosystem of OC. Is clang-tidy a common used tools in OC's world?

I've never used OC too, so we'd definitely need an RFC for that.

If the goal is to disable the check for OC, shouldn't we just do return !LangOpts.ObjC? It expresses intent more clearly. (Although if ObjC isn't set for Objective-C++, that won't work.)

We have further discussion in https://discourse.llvm.org/t/rfc-clang-tidy-which-language-should-be-supported-by-default/88424

…heck

localspook · 2025-09-22T03:25:23Z

Clang-format has an option like this already. Unlike clang-format, we have full semantic information, so this check has the potential to be more reliable, but I’m concerned about duplicating functionality. What do you think?

I don't see a problem in duplicating functionality given clang-tidy would have fever false-positives. We already have https://clang.llvm.org/docs/ClangFormatStyleOptions.html#insertbraces vs https://clang.llvm.org/extra/clang-tidy/checks/readability/braces-around-statements.html

Generally speaking, if clang-format option has warning Setting this option to true could lead to incorrect code formatting due to clang-format’s lack of complete semantic information, I doubt it will be ever enforced in CI but same clang-tidy check could be in CI.

That sounds reasonable, thank you

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h

…heck.h Co-authored-by: Victor Chernyakin <[email protected]>

vbvictor

LGTM with couple nits

clang-tools-extra/test/clang-tidy/checkers/readability/redundant-parentheses.cpp

clang-tools-extra/docs/clang-tidy/checks/readability/redundant-parentheses.rst

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp

clang-tools-extra/docs/clang-tidy/checks/readability/redundant-parentheses.rst

localspook · 2025-09-25T17:40:03Z

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h

+  RedundantParenthesesCheck(StringRef Name, ClangTidyContext *Context)
+      : ClangTidyCheck(Name, Context) {}
+  void registerMatchers(ast_matchers::MatchFinder *Finder) override;
+  void check(const ast_matchers::MatchFinder::MatchResult &Result) override;


If the goal is to disable the check for OC, shouldn't we just do return !LangOpts.ObjC? It expresses intent more clearly. (Although if ObjC isn't set for Objective-C++, that won't work.)

…-parentheses.rst Co-authored-by: Baranov Victor <[email protected]>

…heck

…-parentheses.rst Co-authored-by: Baranov Victor <[email protected]>

…-parentheses.rst Co-authored-by: Victor Chernyakin <[email protected]>

…vm-project into RedundantParenthesesCheck

llvm-ci · 2025-09-26T06:38:47Z

LLVM Buildbot has detected a new failure on builder clang-ppc64le-linux-test-suite running on ppc64le-clang-test-suite while building clang-tools-extra at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/95/builds/18428

Here is the relevant piece of the build log for the reference

Step 6 (test-build-unified-tree-check-all) failure: 1200 seconds without output running [b'ninja', b'check-all'], attempting to kill
...
PASS: LLVM :: MC/Mips/elf_eflags.s (102078 of 102088)
PASS: LLVM :: tools/llvm-objcopy/ELF/cross-arch-headers.test (102079 of 102088)
PASS: LLVM :: tools/llvm-readobj/ELF/mips-abiflags.test (102080 of 102088)
PASS: LLVM :: Object/macho-invalid.test (102081 of 102088)
PASS: LLVM :: tools/llvm-readobj/ELF/note-core.test (102082 of 102088)
PASS: LLVM :: Object/AMDGPU/elf-header-flags-mach.yaml (102083 of 102088)
PASS: LLVM :: tools/llvm-objdump/ELF/AMDGPU/subtarget.ll (102084 of 102088)
PASS: lit :: shtest-define.py (102085 of 102088)
PASS: LLVM :: CodeGen/ARM/build-attributes.ll (102086 of 102088)
PASS: LLVM :: tools/llvm-readobj/ELF/AMDGPU/elf-headers.test (102087 of 102088)
command timed out: 1200 seconds without output running [b'ninja', b'check-all'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=4697.422210
Step 7 (test-build-unified-tree-check-runtimes) failure: test (failure)
******************** TEST 'SanitizerCommon-asan-powerpc64le-Linux :: Linux/getpwnam_r_invalid_user.cpp' FAILED ********************
Exit Code: 134

Command Output (stderr):
--
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/clang  --driver-mode=g++ -gline-tables-only -fsanitize=address  -m64 -fno-function-sections -funwind-tables  -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test -ldl -O0 -g /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/getpwnam_r_invalid_user.cpp -o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/getpwnam_r_invalid_user.cpp.tmp &&  /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/getpwnam_r_invalid_user.cpp.tmp # RUN: at line 2
+ /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=address -m64 -fno-function-sections -funwind-tables -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test -ldl -O0 -g /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/getpwnam_r_invalid_user.cpp -o /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/getpwnam_r_invalid_user.cpp.tmp
+ /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/getpwnam_r_invalid_user.cpp.tmp
getpwnam_r_invalid_user.cpp.tmp: /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/test/sanitizer_common/TestCases/Linux/getpwnam_r_invalid_user.cpp:17: int main(): Assertion `res == 0 || res == ENOENT' failed.
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/getpwnam_r_invalid_user.cpp.script: line 1: 4090512 Aborted                 /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-powerpc64le-Linux/Linux/Output/getpwnam_r_invalid_user.cpp.tmp

--

********************

This check wants to detect a common happened case that forgetting to remove parenthese during modifying code. --------- Co-authored-by: Victor Chernyakin <[email protected]> Co-authored-by: Baranov Victor <[email protected]>

[clang-tidy] add readability-redundant-parentheses

ad8fc03

This check wants to detect a common happened case that forgetting to remove parenthese during modifying code.

llvmbot added clang-tools-extra clang-tidy labels Sep 20, 2025

EugeneZelenko reviewed Sep 20, 2025

View reviewed changes

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.cpp Outdated Show resolved Hide resolved

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h Outdated Show resolved Hide resolved

EugeneZelenko requested review from carlosgalvezp, 5chmidti, localspook and vbvictor September 20, 2025 13:36

vbvictor reviewed Sep 21, 2025

View reviewed changes

HerrCai0907 added 2 commits September 22, 2025 09:52

fix reviwe

863331f

Merge remote-tracking branch 'origin/main' into RedundantParenthesesC…

4799052

…heck

localspook reviewed Sep 22, 2025

View reviewed changes

clang-tools-extra/clang-tidy/readability/RedundantParenthesesCheck.h Outdated Show resolved Hide resolved

HerrCai0907 and others added 2 commits September 23, 2025 15:32

Update clang-tools-extra/clang-tidy/readability/RedundantParenthesesC…

92db784

…heck.h Co-authored-by: Victor Chernyakin <[email protected]>

fix review

42aab95

HerrCai0907 requested a review from vbvictor September 25, 2025 14:51

vbvictor approved these changes Sep 25, 2025

View reviewed changes

localspook reviewed Sep 25, 2025

View reviewed changes

HerrCai0907 and others added 6 commits September 26, 2025 06:33

Update clang-tools-extra/docs/clang-tidy/checks/readability/redundant…

e210b4f

…-parentheses.rst Co-authored-by: Baranov Victor <[email protected]>

Merge remote-tracking branch 'origin/main' into RedundantParenthesesC…

401490d

…heck

Update clang-tools-extra/docs/clang-tidy/checks/readability/redundant…

4ecee58

…-parentheses.rst Co-authored-by: Baranov Victor <[email protected]>

Update clang-tools-extra/docs/clang-tidy/checks/readability/redundant…

b03d891

…-parentheses.rst Co-authored-by: Victor Chernyakin <[email protected]>

fix review

edb5401

Merge branch 'RedundantParenthesesCheck' of github.com:HerrCai0907/ll…

347cfaf

…vm-project into RedundantParenthesesCheck

HerrCai0907 enabled auto-merge (squash) September 25, 2025 23:06

HerrCai0907 merged commit 85aeb6a into llvm:main Sep 25, 2025
11 checks passed

	virtual bool isLanguageVersionSupported(const LangOptions &LangOpts) const {
	return true;
	}

[clang-tidy] add readability-redundant-parentheses #159911

[clang-tidy] add readability-redundant-parentheses #159911

Uh oh!

Conversation

HerrCai0907 commented Sep 20, 2025

Uh oh!

llvmbot commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

localspook commented Sep 20, 2025

Uh oh!

vbvictor commented Sep 20, 2025

Uh oh!

Uh oh!

Uh oh!

vbvictor Sep 21, 2025

Choose a reason for hiding this comment

Uh oh!

HerrCai0907 Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

vbvictor Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

localspook Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

vbvictor Oct 1, 2025

Choose a reason for hiding this comment

Uh oh!

localspook commented Sep 22, 2025

Uh oh!

Uh oh!

vbvictor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

localspook Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

llvm-ci commented Sep 26, 2025

Uh oh!

Uh oh!

llvmbot commented Sep 20, 2025 •

edited

Loading