Skip to content

Conversation

Ahajha
Copy link
Contributor

@Ahajha Ahajha commented Sep 20, 2025

Relands #157173 (reverts #157995).

The stubgen was relanded here: #157930

@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Sep 20, 2025
Comment on lines 35 to 41
filegroup(
name = "ExecutionEnginePyIFiles",
srcs = [
"mlir/_mlir_libs/_mlirExecutionEngine.pyi",
],
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one wasn't removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, checking locally currently.

Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Developer Policy and LLVM Discourse for more information.

Comment on lines 694 to 685
filegroup(
name = "PDLPyIFiles",
srcs = [
"mlir/_mlir_libs/_mlir/dialects/pdl.pyi",
],
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nor this one (nor the quant.pyi below).

@Ahajha Ahajha force-pushed the revert-157995-ahajha/revert-stubgen-bazel branch from bfa5395 to 2e0f894 Compare September 20, 2025 19:14
Copy link
Contributor

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even though I don't actually know bazel 🤷

@Ahajha
Copy link
Contributor Author

Ahajha commented Sep 20, 2025

Thanks :) Double checking things are working for me locally

@Ahajha
Copy link
Contributor Author

Ahajha commented Sep 20, 2025

Okay I think things are good, I'll follow up if there are more to remove.

@Ahajha
Copy link
Contributor Author

Ahajha commented Sep 22, 2025

All that's left is the WORKSPACE, indifferent if this gets merged now (we don't use it), but someone else might want it.

@rupprecht
Copy link
Collaborator

All that's left is the WORKSPACE, indifferent if this gets merged now (we don't use it), but someone else might want it.

Same, I had bumped the version to 2.9.2 because I thought we might need it, but we don't. I think we might as well use the same version for consistency though.

@Ahajha
Copy link
Contributor Author

Ahajha commented Sep 22, 2025

@rupprecht would you mind merging? I don't have write access (I'll have to ask Chris for that at some point).

@rupprecht rupprecht merged commit 1ee1895 into llvm:main Sep 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bazel "Peripheral" support tier build system: utils/bazel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants