-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Reland "[bazel][mlir][python] Port #155741: stub auto-generation" #159940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "[bazel][mlir][python] Port #155741: stub auto-generation" #159940
Conversation
filegroup( | ||
name = "ExecutionEnginePyIFiles", | ||
srcs = [ | ||
"mlir/_mlir_libs/_mlirExecutionEngine.pyi", | ||
], | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one wasn't removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, checking locally currently.
|
filegroup( | ||
name = "PDLPyIFiles", | ||
srcs = [ | ||
"mlir/_mlir_libs/_mlir/dialects/pdl.pyi", | ||
], | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nor this one (nor the quant.pyi
below).
bfa5395
to
2e0f894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM even though I don't actually know bazel 🤷
Thanks :) Double checking things are working for me locally |
Okay I think things are good, I'll follow up if there are more to remove. |
All that's left is the |
Same, I had bumped the version to 2.9.2 because I thought we might need it, but we don't. I think we might as well use the same version for consistency though. |
@rupprecht would you mind merging? I don't have write access (I'll have to ask Chris for that at some point). |
Relands #157173 (reverts #157995).
The stubgen was relanded here: #157930