Skip to content

[clang] Accept empty enum in MSVC compatible C #159981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[clang] Accept empty enum in MSVC compatible C #159981

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
77fc06c
[clang] Accept empty enum in MSVC compatible C
yicuixi Sep 21, 2025
191eacf
Fix test
yicuixi Sep 21, 2025
e153bf2
Merge branch 'main' into ms-ext
yicuixi Sep 24, 2025
c106aaa
address comments
yicuixi Sep 24, 2025
6bb40da
correct format
yicuixi Sep 26, 2025
d9ab0fe
Merge branch 'main' into ms-ext
yicuixi Sep 28, 2025
f573438
Merge branch 'main' into ms-ext
yicuixi Sep 28, 2025
b1cbba5
Update clang/docs/ReleaseNotes.rst
yicuixi Sep 30, 2025
4dfd0fd
Merge branch 'main' into ms-ext
yicuixi Oct 19, 2025
259e58d
[clang] Add CodeGen test to check the ABI compatibility
yicuixi Oct 20, 2025
394ae9c
Fix test
yicuixi Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ Bug Fixes in This Version
- Fixed an assertion when an improper use of the ``malloc`` attribute targeting
a function without arguments caused us to try to access a non-existent argument.
(#GH159080)
- Accept empty enum in MSVC-compatible C. (#GH114402)

Bug Fixes to Compiler Builtins
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
3 changes: 2 additions & 1 deletion clang/lib/Parse/ParseDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5360,7 +5360,8 @@ void Parser::ParseEnumBody(SourceLocation StartLoc, Decl *EnumDecl,
T.consumeOpen();

// C does not allow an empty enumerator-list, C++ does [dcl.enum].
if (Tok.is(tok::r_brace) && !getLangOpts().CPlusPlus)
if (Tok.is(tok::r_brace) && !getLangOpts().CPlusPlus &&
!getLangOpts().MSVCCompat && !getLangOpts().MicrosoftExt)
Diag(Tok, diag::err_empty_enum);

SmallVector<Decl *, 32> EnumConstantDecls;
Expand Down
7 changes: 7 additions & 0 deletions clang/test/Parser/ms-empty-enum.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// RUN: %clang_cc1 %s -fsyntax-only -Wmicrosoft -verify -fms-extensions
// RUN: %clang_cc1 %s -fsyntax-only -Wmicrosoft -verify -fms-compatibility

typedef enum tag1 { } A;
typedef enum tag2 { } B;
typedef enum : unsigned { } C; // expected-warning {{enumeration types with a fixed underlying type are a Microsoft extension}}