[libcxx] Add local %T substitution #160026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Aiden Grossman (boomanaiden154) ChangesThis patch adds a %T substitution directly into the libc++ test format. Full diff: https://github.com/llvm/llvm-project/pull/160026.diff 1 Files Affected:
diff --git a/libcxx/utils/libcxx/test/format.py b/libcxx/utils/libcxx/test/format.py
index 5765afec399cf..c9dffd1bb7971 100644
--- a/libcxx/utils/libcxx/test/format.py
+++ b/libcxx/utils/libcxx/test/format.py
@@ -92,6 +92,7 @@ def parseScript(test, preamble):
# errors, which doesn't make sense for clang-verify tests because we may want to check
# for specific warning diagnostics.
_checkBaseSubstitutions(substitutions)
+ substitutions.append(("%T", tmpDir))
substitutions.append(
("%{build}", "%{cxx} %s %{flags} %{compile_flags} %{link_flags} -o %t.exe")
)
|
|
I'm going to land this given all the CI is passing (minus the flaky arm bots) and that it is pretty trivial. If there is any postcommit followup needed, please let me know and I'll address any comments there. I want to get this in reasonably soon to ensure we don't backslide on having |
boomanaiden154
deleted the
users/boomanaiden154/libcxx-add-local-t-substitution
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 26, 2025
This patch adds a %T substitution directly into the libc++ test format. This ensures that the libc++ test format will continue to work when we remove support for %T in llvm lit. Reviewers: #reviewers-libcxx, ldionne, philnik777 Pull Request: llvm/llvm-project#160026
ldionne
reviewed
Sep 29, 2025
| # errors, which doesn't make sense for clang-verify tests because we may want to check | ||
| # for specific warning diagnostics. | ||
| _checkBaseSubstitutions(substitutions) | ||
| substitutions.append(("%T", tmpDir)) |
There was a problem hiding this comment.
I would suggest introducing this as %{temp} and documenting it officially as a substitution added by the libc++ testing format instead. Once %T is removed in Lit, this substitution will become seemingly random for anybody who isn't familiar with the current %T substitution provided by Lit.
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
This patch adds a %T substitution directly into the libc++ test format. This ensures that the libc++ test format will continue to work when we remove support for %T in llvm lit. Reviewers: #reviewers-libcxx, ldionne, philnik777 Pull Request: llvm#160026
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Oct 7, 2025
Based on review feedback in llvm#160026. This makes the substitution a lot more clear now that there is no documentation around %T.
boomanaiden154
added a commit
that referenced
this pull request
Oct 9, 2025
Based on review feedback in #160026. This makes the substitution a lot more clear now that there is no documentation around %T. --------- Co-authored-by: Louis Dionne <[email protected]>
dcandler
added a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 10, 2025
Support for the `%T` temp dir substitution is being removed from lit.
The libc++ testing format is instead introducing `%{temp}` to replace
it, and the downstream test configurations need updating to match.
For reference, see:
llvm/llvm-project#160026
llvm/llvm-project#162323
DharuniRAcharya
pushed a commit
to DharuniRAcharya/llvm-project
that referenced
this pull request
Oct 13, 2025
Based on review feedback in llvm#160026. This makes the substitution a lot more clear now that there is no documentation around %T. --------- Co-authored-by: Louis Dionne <[email protected]>
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
Based on review feedback in llvm#160026. This makes the substitution a lot more clear now that there is no documentation around %T. --------- Co-authored-by: Louis Dionne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a %T substitution directly into the libc++ test format.
This ensures that the libc++ test format will continue to work when we
remove support for %T in llvm lit.