Skip to content

[libc++] Fix use of static in constexpr #160180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

[libc++] Fix use of static in constexpr #160180

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2a2061
[libc++] Fix use of static in constexpr
Prabhuk Sep 22, 2025
a075374
Update libcxx/include/__algorithm/make_heap.h
Prabhuk Sep 22, 2025
f75f7e3
Merge branch 'main' into libcxx_static_in_constexpr
Prabhuk Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libcxx/include/__algorithm/make_heap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ __make_heap(_RandomAccessIterator __first, _RandomAccessIterator __last, _Compar
using __diff_t = __iter_diff_t<_RandomAccessIterator>;
const __diff_t __n = __last - __first;

static const bool __assume_both_children = is_arithmetic<__iter_value_type<_RandomAccessIterator> >::value;
_LIBCPP_CONSTEXPR_SINCE_CXX14 const bool __assume_both_children =
is_arithmetic<__iter_value_type<_RandomAccessIterator> >::value;

// While it would be correct to always assume we have both children, in practice we observed this to be a performance
// improvement only for arithmetic types.
Expand Down
Loading