[BOLT] Improve unmarked-data.test #160263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test checked for no BOLT-WARNINGs without specifying the expected warning. This caused the test to fail on warning unrelated to the test. Added the BOLT-WARNING that was present before 8579db9.
bgergely0
requested review from
aaupov,
ayermolo,
maksfb,
paschalis-mpeis,
rafaelauler,
yota9 and
yozhu
as code owners
Member
|
@llvm/pr-subscribers-bolt Author: Gergely Bálint (bgergely0) ChangesThe test checked for no BOLT-WARNINGs without specifying the expected warning. This caused the test to fail on warning unrelated to the test. Added the BOLT-WARNING that was present before 8579db9. Full diff: https://github.com/llvm/llvm-project/pull/160263.diff 1 Files Affected:
diff --git a/bolt/test/AArch64/unmarked-data.test b/bolt/test/AArch64/unmarked-data.test
index 7a62994bb5c38..af6de11f3df60 100644
--- a/bolt/test/AArch64/unmarked-data.test
+++ b/bolt/test/AArch64/unmarked-data.test
@@ -2,7 +2,7 @@
// RUN: yaml2obj %S/Inputs/unmarked-data.yaml -o %t.exe
// RUN: llvm-bolt %t.exe -o %t.bolt --lite=0 --use-old-text=0 2>&1 | FileCheck %s
-// CHECK-NOT: BOLT-WARNING
+// CHECK-NOT: BOLT-WARNING: unable to disassemble instruction at offset
// RUN: llvm-objdump -j .text -d --disassemble-symbols=first,second %t.bolt | FileCheck %s -check-prefix=CHECK-SYMBOL
// CHECK-SYMBOL: <first>:
// CHECK-SYMBOL: <second>:
|
Merged
8 tasks
bgergely0
added a commit
to bgergely0/llvm-project
that referenced
this pull request
Sep 30, 2025
Remove the workaround for the issue that was fixed in llvm#160263.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test checked for no BOLT-WARNINGs without specifying the expected warning. This caused the test to fail on warnings unrelated to the test.
Added the BOLT-WARNING that was present before 8579db9.