Skip to content

[z.OS] fix strnlen() usage in Context.cpp available on z/OS #160339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zibi2 merged 1 commit into from
Sep 23, 2025
Merged

[z.OS] fix strnlen() usage in Context.cpp available on z/OS #160339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/lib/AST/ByteCode/Context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "clang/AST/ASTLambda.h"
#include "clang/AST/Expr.h"
#include "clang/Basic/TargetInfo.h"
#include "llvm/Support/SystemZ/zOSSupport.h"
Copy link
Contributor

@perry-ca perry-ca Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will get deleted again. The compiles on other platforms are going to say this header is empty and it will get removed again.

What I was thinking should do is:

  1. create a wrapper header dir that is just for building llvm. This can live in the llvm repo (or we prereq the zoslib repo which has this already)
  • create a stdlib.h that has the strnlen() in it
  1. add a -isystem option to include this wrapper.

I'm good with the change. Just worried it will get undone.

Copy link
Contributor Author

@zibi2 zibi2 Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for suggestion.

This header is included in 1/2 a dozen places and it was not removed so far but when it does I will look into your suggestion.


using namespace clang;
using namespace clang::interp;
Expand Down