[NFC][PowerPC] Lockdown instructions of vspltisw for addition of vector of 1s #160476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-backend-powerpc Author: None (Himadhith) ChangesThis NFC patch looks to lock down the instruction generated for the operation of Full diff: https://github.com/llvm/llvm-project/pull/160476.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/PowerPC/vector-all-ones.ll b/llvm/test/CodeGen/PowerPC/vector-all-ones.ll
new file mode 100644
index 0000000000000..7ad41482ffe81
--- /dev/null
+++ b/llvm/test/CodeGen/PowerPC/vector-all-ones.ll
@@ -0,0 +1,47 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 6
+; RUN: llc -verify-machineinstrs -mcpu=pwr9 -mtriple=powerpc64le-unknown-linux-gnu \
+; RUN: -ppc-asm-full-reg-names --ppc-vsr-nums-as-vr < %s | FileCheck %s --check-prefix=POWERPC_64LE
+
+; RUN: llc -verify-machineinstrs -mcpu=pwr9 -mtriple=powerpc64-ibm-aix \
+; RUN: -ppc-asm-full-reg-names --ppc-vsr-nums-as-vr < %s | FileCheck %s --check-prefix=POWERPC_64
+
+; RUN: llc -verify-machineinstrs -mcpu=pwr9 -mtriple=powerpc-ibm-aix \
+; RUN: -ppc-asm-full-reg-names --ppc-vsr-nums-as-vr < %s | FileCheck %s --check-prefix=POWERPC_32
+
+; Currently the generated code uses `vspltisw` to generate vector of 1s followed by add operation.
+; This pattern is expected to be optimized in a future patch by using `xxleqv` to generate vector of -1s
+; followed by subtraction operation.
+define dso_local <4 x i32> @test1(<4 x i32> %a) {
+; POWERPC_64LE-LABEL: test1:
+; POWERPC_64LE: # %bb.0: # %entry
+; POWERPC_64LE-NEXT: vspltisw v3, 1
+; POWERPC_64LE-NEXT: stxv v2, -16(r1)
+; POWERPC_64LE-NEXT: vadduwm v2, v2, v3
+; POWERPC_64LE-NEXT: stxv v3, -32(r1)
+; POWERPC_64LE-NEXT: blr
+;
+; POWERPC_64-LABEL: test1:
+; POWERPC_64: # %bb.0: # %entry
+; POWERPC_64-NEXT: vspltisw v3, 1
+; POWERPC_64-NEXT: stxv v2, -16(r1)
+; POWERPC_64-NEXT: vadduwm v2, v2, v3
+; POWERPC_64-NEXT: stxv v3, -32(r1)
+; POWERPC_64-NEXT: blr
+;
+; POWERPC_32-LABEL: test1:
+; POWERPC_32: # %bb.0: # %entry
+; POWERPC_32-NEXT: vspltisw v3, 1
+; POWERPC_32-NEXT: stxv v2, -16(r1)
+; POWERPC_32-NEXT: vadduwm v2, v2, v3
+; POWERPC_32-NEXT: stxv v3, -32(r1)
+; POWERPC_32-NEXT: blr
+entry:
+ %a.addr = alloca <4 x i32>, align 16
+ %b = alloca <4 x i32>, align 16
+ store <4 x i32> %a, ptr %a.addr, align 16
+ store <4 x i32> splat (i32 1), ptr %b, align 16
+ %0 = load <4 x i32>, ptr %a.addr, align 16
+ %1 = load <4 x i32>, ptr %b, align 16
+ %add = add <4 x i32> %0, %1
+ ret <4 x i32> %add
+}
|
Contributor
|
Is there an existing PR that will optimize this code gen? |
Himadhith
force-pushed
the
himadhith/NFC_vector_all_ones
branch
from
75f2131 to
f154ac2
Compare
Contributor
Author
[PowerPC] Replace vspltisw+vadduwm instructions with xxleqv+vsubuwm for adding the vector {1, 1, 1, 1} |
lei137
reviewed
Sep 26, 2025
| ; RUN: -ppc-asm-full-reg-names --ppc-vsr-nums-as-vr < %s | FileCheck %s --check-prefix=POWERPC_64 | ||
|
|
||
| ; RUN: llc -verify-machineinstrs -O3 -mtriple=powerpc-ibm-aix \ | ||
| ; RUN: -ppc-asm-full-reg-names --ppc-vsr-nums-as-vr < %s | FileCheck %s --check-prefix=POWERPC_32 |
Contributor
There was a problem hiding this comment.
All 3 set of checks are the same AFAICT... is there a reason we need all 3 to be explicit vs just using the default CHECK?
Contributor
Author
There was a problem hiding this comment.
Oh yea good point, thanks. No explicit reason for needing all 3 checks, I will change it to use the default CHECK.
Himadhith
force-pushed
the
himadhith/NFC_vector_all_ones
branch
from
f154ac2 to
908c6b8
Compare
lei137
changed the title
lei137
changed the title
lei137
approved these changes
Sep 26, 2025
Contributor
lei137
left a comment
lei137
left a comment
There was a problem hiding this comment.
I updated your PR title since you repeated NFC in it.
Contributor
Author
Thank you! |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/15238 Here is the relevant piece of the build log for the reference |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…lvm#160476) This NFC patch looks to lock down the instruction generated for the operation of `A + vector {1, 1, 1, 1}` in which the current code emits `vspltisw`. It can be made better with the use of a `2 cycle` instruction `xxleqv` over the current `4 cycle vspltisw`. --------- Co-authored-by: himadhith <[email protected]>
tonykuttai
pushed a commit
that referenced
this pull request
Oct 16, 2025
…8 into exisiting testfile (#163201) The previous [NFC patch](#160476 (comment)) addressed only the vector type `v4i32`, this is a continuation for the previous patch which adds the remaining 3 vector types which were left out. This should include the following operands: - `v2i64`: `A + vector {1, 1,}` - `v8i16`: `A + vector {1, 1, 1, 1, 1, 1, 1, 1}` - `v16i8`: `A + vector {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}` --------- Co-authored-by: himadhith <[email protected]>
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 16, 2025
…16 and v16i8 into exisiting testfile (#163201) The previous [NFC patch](llvm/llvm-project#160476 (comment)) addressed only the vector type `v4i32`, this is a continuation for the previous patch which adds the remaining 3 vector types which were left out. This should include the following operands: - `v2i64`: `A + vector {1, 1,}` - `v8i16`: `A + vector {1, 1, 1, 1, 1, 1, 1, 1}` - `v16i8`: `A + vector {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1}` --------- Co-authored-by: himadhith <[email protected]>
Himadhith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This NFC patch looks to lock down the instruction generated for the operation of
A + vector {1, 1, 1, 1}in which the current code emitsvspltisw.It can be made better with the use of a
2 cycleinstructionxxleqvover the current4 cycle vspltisw.