-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[libcxx] Implement C++20 std::chrono::is_clock, std::chrono::is_clock_v #160607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuxuanchen1997
wants to merge
14
commits into
main
Choose a base branch
from
users/yuxuanchen1997/libcxx-is-clock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
74f494a
[libcxx] Implement C++20 std::chrono::is_clock, std::chrono::is_clock_v
yuxuanchen1997 5fcfd58
Apply suggestions in libcxx/include/__chrono/is_clock.h
yuxuanchen1997 5c09a5d
address comments
yuxuanchen1997 7f1ad78
only test steady_clock if a macro is set
yuxuanchen1997 11329c1
format in test
yuxuanchen1997 bd7ca12
more strict checks
yuxuanchen1997 12a38fb
apply suggestions to test file
yuxuanchen1997 3af9f2d
simplify time_point checks
yuxuanchen1997 1871808
Merge branch 'main' into users/yuxuanchen1997/libcxx-is-clock
yuxuanchen1997 5340360
include <ratio>
yuxuanchen1997 4afb48a
fix AIX CI
yuxuanchen1997 4a01d77
fix monotonic clock check
yuxuanchen1997 89223a8
still check for specialization
yuxuanchen1997 6f7a8a6
fix if _LIBCPP_HAS_MONOTONIC_CLOCK
yuxuanchen1997 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// -*- C++ -*- | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#ifndef _LIBCPP___CHRONO_IS_CLOCK_H | ||
#define _LIBCPP___CHRONO_IS_CLOCK_H | ||
|
||
#include <__config> | ||
|
||
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) | ||
# pragma GCC system_header | ||
#endif | ||
|
||
#if _LIBCPP_STD_VER >= 20 | ||
|
||
# include <__type_traits/integral_constant.h> | ||
yuxuanchen1997 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
_LIBCPP_BEGIN_NAMESPACE_STD | ||
|
||
namespace chrono { | ||
|
||
template <class _Tp> | ||
_LIBCPP_NO_SPECIALIZATIONS inline constexpr bool is_clock_v = requires { | ||
typename _Tp::rep; | ||
typename _Tp::period; | ||
typename _Tp::duration; | ||
typename _Tp::time_point; | ||
_Tp::is_steady; | ||
_Tp::now(); | ||
}; | ||
|
||
template <class _Tp> | ||
struct _LIBCPP_NO_SPECIALIZATIONS is_clock : bool_constant<is_clock_v<_Tp>> {}; | ||
|
||
} // namespace chrono | ||
|
||
_LIBCPP_END_NAMESPACE_STD | ||
|
||
#endif // _LIBCPP_STD_VER | ||
#endif // _LIBCPP___CHRONO_IS_CLOCK_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
129 changes: 129 additions & 0 deletions
129
libcxx/test/std/time/time.traits.is.clock/trait.is.clock.pass.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,129 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
// REQUIRES: std-at-least-c++20 | ||
|
||
#include <chrono> | ||
#include <ratio> | ||
|
||
struct EmptyStruct {}; | ||
|
||
// Test structs missing required members | ||
struct MissingRep { | ||
using period = std::ratio<1>; | ||
using duration = std::chrono::seconds; | ||
using time_point = std::chrono::time_point<MissingRep>; | ||
static constexpr bool is_steady = false; | ||
static time_point now(); | ||
}; | ||
|
||
struct MissingPeriod { | ||
using rep = long; | ||
using duration = std::chrono::seconds; | ||
using time_point = std::chrono::time_point<MissingPeriod>; | ||
static constexpr bool is_steady = false; | ||
static time_point now(); | ||
}; | ||
|
||
struct MissingDuration { | ||
using rep = long; | ||
using time_point = long; | ||
static constexpr bool is_steady = false; | ||
static time_point now(); | ||
}; | ||
|
||
struct MissingTimePoint { | ||
using rep = long; | ||
using period = std::ratio<1>; | ||
using duration = std::chrono::seconds; | ||
static constexpr bool is_steady = false; | ||
static std::chrono::time_point<MissingTimePoint> now(); | ||
}; | ||
|
||
struct MissingIsSteady { | ||
using rep = long; | ||
using period = std::ratio<1>; | ||
using duration = std::chrono::seconds; | ||
using time_point = std::chrono::time_point<MissingIsSteady>; | ||
static time_point now(); | ||
}; | ||
|
||
struct MissingNow { | ||
using rep = long; | ||
using period = std::ratio<1>; | ||
using duration = std::chrono::seconds; | ||
using time_point = std::chrono::time_point<MissingNow>; | ||
static constexpr bool is_steady = false; | ||
}; | ||
|
||
// Valid clock types | ||
struct ValidSteadyClock { | ||
using rep = long long; | ||
using period = std::nano; | ||
using duration = std::chrono::nanoseconds; | ||
using time_point = std::chrono::time_point<ValidSteadyClock>; | ||
static constexpr bool is_steady = true; | ||
static time_point now(); | ||
}; | ||
|
||
struct ValidSystemClock { | ||
using rep = int64_t; | ||
using period = std::micro; | ||
using duration = std::chrono::microseconds; | ||
using time_point = std::chrono::time_point<ValidSystemClock>; | ||
static constexpr bool is_steady = false; | ||
static time_point now(); | ||
}; | ||
|
||
int main(int, char**) { | ||
// Test both is_clock and is_clock_v | ||
static_assert(std::chrono::is_clock<std::chrono::system_clock>::value); | ||
static_assert(std::chrono::is_clock_v<std::chrono::system_clock>); | ||
|
||
// Test standard clock types | ||
static_assert(std::chrono::is_clock_v<std::chrono::system_clock>); | ||
static_assert(std::chrono::is_clock_v<std::chrono::steady_clock>); | ||
static_assert(std::chrono::is_clock_v<std::chrono::high_resolution_clock>); | ||
|
||
// Test non-clock types | ||
static_assert(!std::chrono::is_clock_v<EmptyStruct>); | ||
static_assert(!std::chrono::is_clock_v<int>); | ||
static_assert(!std::chrono::is_clock_v<void>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::system_clock::time_point>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::steady_clock::time_point>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::seconds>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::milliseconds>); | ||
|
||
// Test structs missing required members | ||
static_assert(!std::chrono::is_clock_v<MissingRep>); | ||
static_assert(!std::chrono::is_clock_v<MissingPeriod>); | ||
static_assert(!std::chrono::is_clock_v<MissingDuration>); | ||
static_assert(!std::chrono::is_clock_v<MissingTimePoint>); | ||
static_assert(!std::chrono::is_clock_v<MissingIsSteady>); | ||
static_assert(!std::chrono::is_clock_v<MissingNow>); | ||
|
||
// Test valid custom clocks | ||
static_assert(std::chrono::is_clock_v<ValidSteadyClock>); | ||
static_assert(std::chrono::is_clock_v<ValidSystemClock>); | ||
|
||
// cv-qualified and reference types | ||
static_assert(std::chrono::is_clock_v<const std::chrono::system_clock>); | ||
static_assert(std::chrono::is_clock_v<volatile std::chrono::system_clock>); | ||
static_assert(std::chrono::is_clock_v<const volatile std::chrono::system_clock>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::system_clock&>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::system_clock&&>); | ||
static_assert(!std::chrono::is_clock_v<const std::chrono::system_clock&>); | ||
|
||
// array and pointer types | ||
static_assert(!std::chrono::is_clock_v<std::chrono::system_clock[]>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::system_clock[10]>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::system_clock*>); | ||
static_assert(!std::chrono::is_clock_v<std::chrono::system_clock* const>); | ||
|
||
return 0; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.