Skip to content

[SPIRV] Fix code quality issues. #160752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

[SPIRV] Fix code quality issues. #160752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
926d628
[SPIRV] Fix code quality issues.
maarquitos14 Sep 25, 2025
baed177
Merge branch 'main' into maronas/code-quality-fixes
maarquitos14 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/lib/Target/SPIRV/SPIRVLegalizerInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,8 @@ bool SPIRVLegalizerInfo::legalizeIsFPClass(
}

if (FPClassTest PartialCheck = Mask & fcNan) {
auto InfWithQnanBitC = buildSPIRVConstant(IntTy, Inf | QNaNBitMask);
auto InfWithQnanBitC =
buildSPIRVConstant(IntTy, std::move(Inf) | QNaNBitMask);
if (PartialCheck == fcNan) {
// isnan(V) ==> abs(V) u> int(inf)
appendToRes(
Expand All @@ -613,7 +614,7 @@ bool SPIRVLegalizerInfo::legalizeIsFPClass(
APInt ExpLSB = ExpMask & ~(ExpMask.shl(1));
auto ExpMinusOne = assignSPIRVTy(
MIRBuilder.buildSub(IntTy, Abs, buildSPIRVConstant(IntTy, ExpLSB)));
APInt MaxExpMinusOne = ExpMask - ExpLSB;
APInt MaxExpMinusOne = std::move(ExpMask) - ExpLSB;
auto NormalRes = assignSPIRVTy(
MIRBuilder.buildICmp(CmpInst::Predicate::ICMP_ULT, DstTy, ExpMinusOne,
buildSPIRVConstant(IntTy, MaxExpMinusOne)));
Expand Down
Loading