Skip to content

Revert changes to llvm-string stdin test and XFAIL on AIX #160821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
Merged

Revert changes to llvm-string stdin test and XFAIL on AIX #160821

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3bbae3
Revert changes to llvm-string stdin test and XFAIL on AIX
madanial0 Sep 26, 2025
0b030e9
Address review comment
madanial0 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions llvm/test/tools/llvm-strings/stdin.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
; XFAIL: target={{.*}}-aix{{.*}}
Copy link
Collaborator

@jh7370 jh7370 Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct. It'll XFAIL the test if the AIX target is enabled, when it should be when the host system is AIX.


## Show that llvm-strings can handle stdin input properly.

## Case 1: output with single string.
RUN: echo -n "abcdefg" > %t
RUN: llvm-strings %t - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}}
RUN: echo -n "abcdefg" | llvm-strings - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}}
CASE1: abcdefg

## Case 2: output too short for string.
RUN: echo -n "abc" > %t
RUN: llvm-strings %t - | FileCheck %s --implicit-check-not={{.}} --allow-empty
RUN: echo -n "abc" | llvm-strings - | FileCheck %s --implicit-check-not={{.}} --allow-empty

## Case 3: output with new line.
RUN: printf "abcd\nefgh" | llvm-strings - | FileCheck %s --check-prefix=CASE3 --implicit-check-not={{.}}
Expand All @@ -21,5 +21,4 @@ CASE4-NEXT: ghij
CASE4-NEXT: klmn

## Case 5: no file name specified is equivalent to explicitly requesting stdin.
RUN: echo -n "abcdefg" > %t
RUN: llvm-strings %t - | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}}
RUN: echo -n "abcdefg" | llvm-strings | FileCheck %s --check-prefix=CASE1 --implicit-check-not={{.}}
Loading