Skip to content

[LLDB] Handle i686 mingw32 mangling prefix #160930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[LLDB] Handle i686 mingw32 mangling prefix #160930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lldb/source/Core/Mangled.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ Mangled::ManglingScheme Mangled::GetManglingScheme(llvm::StringRef const name) {
if (name.starts_with("_Z"))
return Mangled::eManglingSchemeItanium;

// __Z is used on i686 mingw32
if (name.starts_with("__Z"))
return Mangled::eManglingSchemeItanium;

// ___Z is a clang extension of block invocations
if (name.starts_with("___Z"))
return Mangled::eManglingSchemeItanium;
Expand Down
17 changes: 17 additions & 0 deletions lldb/unittests/Core/MangledTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,23 @@ TEST(MangledTest, SameForInvalidDLangPrefixedName) {
EXPECT_STREQ("_DDD", the_demangled.GetCString());
}

TEST(MangledTest, ResultForValidMingw32Name) {
ConstString mangled_name("__Z7recursei");
Mangled the_mangled(mangled_name);
ConstString the_demangled = the_mangled.GetDemangledName();

ConstString expected_result("recurse(int)");
EXPECT_STREQ(expected_result.GetCString(), the_demangled.GetCString());
}

TEST(MangledTest, EmptyForInvalidMingw32Name) {
ConstString mangled_name("__Zzrecursei");
Mangled the_mangled(mangled_name);
ConstString the_demangled = the_mangled.GetDemangledName();

EXPECT_STREQ("", the_demangled.GetCString());
}

TEST(MangledTest, RecognizeSwiftMangledNames) {
llvm::StringRef valid_swift_mangled_names[] = {
"_TtC4main7MyClass", // Mangled objc class name
Expand Down
Loading