Skip to content

[clang] Fix a use-after free in ASTContext::getSubstBuiltinTemplatePack #160970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2025
Merged

[clang] Fix a use-after free in ASTContext::getSubstBuiltinTemplatePack #160970

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea310a6
[clang] Fix a use-after free in ASTContext::getSubstBuiltinTemplatePack
alexfh Sep 27, 2025
edff46e
Address review comments.
alexfh Sep 27, 2025
6f8d3ef
Merge branch 'main' into fix-clang-asan-error
alexfh Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion clang/lib/AST/ASTContext.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5873,8 +5873,14 @@ ASTContext::getSubstBuiltinTemplatePack(const TemplateArgument &ArgPack) {

QualType Canon;
TemplateArgument CanonArgPack = getCanonicalTemplateArgument(ArgPack);
if (!CanonArgPack.structurallyEquals(ArgPack))
if (!CanonArgPack.structurallyEquals(ArgPack)) {
Canon = getSubstBuiltinTemplatePack(CanonArgPack);
// Refresh InsertPos, in case the recursive call above caused rehashing,
// which would invalidate the bucket pointer.
[[maybe_unused]] const auto *Nothing =
SubstBuiltinTemplatePackTypes.FindNodeOrInsertPos(ID, InsertPos);
assert(!Nothing);
}

auto *PackType = new (*this, alignof(SubstBuiltinTemplatePackType))
SubstBuiltinTemplatePackType(Canon, ArgPack);
Expand Down