[GitHub][docker] Fix 'FromAsCasing' violation in CI dockerfile #161017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-github-workflow Author: Baranov Victor (vbvictor) ChangesFixes https://docs.docker.com/reference/build-checks/from-as-casing/ Full diff: https://github.com/llvm/llvm-project/pull/161017.diff 1 Files Affected:
diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index f5422b4527576..c887dc7418abf 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -1,7 +1,7 @@
-FROM docker.io/library/ubuntu:24.04 as base
+FROM docker.io/library/ubuntu:24.04 AS base
ENV LLVM_SYSROOT=/opt/llvm
-FROM base as stage1-toolchain
+FROM base AS stage1-toolchain
ENV LLVM_VERSION=21.1.0
RUN apt-get update && \
@@ -37,7 +37,7 @@ RUN cmake -B ./build -G Ninja ./llvm \
RUN ninja -C ./build stage2-clang-bolt stage2-install-distribution && ninja -C ./build install-distribution
-FROM base as ci-container
+FROM base AS ci-container
COPY --from=stage1-toolchain $LLVM_SYSROOT $LLVM_SYSROOT
@@ -97,7 +97,7 @@ RUN echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers
USER gha
WORKDIR /home/gha
-FROM ci-container as ci-container-agent
+FROM ci-container AS ci-container-agent
ENV GITHUB_RUNNER_VERSION=2.328.0
|
boomanaiden154
approved these changes
Sep 27, 2025
vbvictor
force-pushed
the
fix-from-as-casing-docker
branch
from
4b25ecf to
8f9c38d
Compare
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…161017) Fixes https://docs.docker.com/reference/build-checks/from-as-casing/ which also gives warning when building container from command line: ``` => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1) => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 4) => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 40) => WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 100) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://docs.docker.com/reference/build-checks/from-as-casing/
which also gives warning when building container from command line: