-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[Flang] Add parsing and attribute registration for SIMPLE specifier #161285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mlir-maiden
wants to merge
2
commits into
llvm:main
Choose a base branch
from
mlir-maiden:simple-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -265,6 +265,7 @@ class AttrsVisitor : public virtual BaseVisitor { | |
| HANDLE_ATTR_CLASS(PrefixSpec::Non_Recursive, NON_RECURSIVE) | ||
| HANDLE_ATTR_CLASS(PrefixSpec::Pure, PURE) | ||
| HANDLE_ATTR_CLASS(PrefixSpec::Recursive, RECURSIVE) | ||
| HANDLE_ATTR_CLASS(PrefixSpec::Simple, SIMPLE) | ||
| HANDLE_ATTR_CLASS(TypeAttrSpec::BindC, BIND_C) | ||
| HANDLE_ATTR_CLASS(BindAttr::Deferred, DEFERRED) | ||
| HANDLE_ATTR_CLASS(BindAttr::Non_Overridable, NON_OVERRIDABLE) | ||
|
|
@@ -2350,6 +2351,7 @@ bool AttrsVisitor::IsConflictingAttr(Attr attrName) { | |
| HaveAttrConflict(attrName, Attr::INTENT_INOUT, Attr::INTENT_OUT) || | ||
| HaveAttrConflict(attrName, Attr::PASS, Attr::NOPASS) || // C781 | ||
| HaveAttrConflict(attrName, Attr::PURE, Attr::IMPURE) || | ||
| HaveAttrConflict(attrName, Attr::PURE, Attr::SIMPLE) || | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you sure that this case should be an error? |
||
| HaveAttrConflict(attrName, Attr::PUBLIC, Attr::PRIVATE) || | ||
| HaveAttrConflict(attrName, Attr::RECURSIVE, Attr::NON_RECURSIVE) || | ||
| HaveAttrConflict(attrName, Attr::INTRINSIC, Attr::EXTERNAL); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| ! RUN: %flang_fc1 -fdebug-unparse-no-sema %s 2>&1 | FileCheck %s | ||
|
|
||
| ! Test that SIMPLE function specifier is recognized | ||
| ! by the parser and the unparser. This test does not | ||
| ! exercise semantic checks. | ||
|
|
||
| simple function foo() | ||
| return | ||
| end function | ||
|
|
||
| ! CHECK: SIMPLE FUNCTION foo() | ||
| ! CHECK-NEXT: RETURN | ||
| ! CHECK-NEXT: END FUNCTION | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| ! RUN: %flang_fc1 -fdebug-dump-parse-tree %s | FileCheck %s | ||
|
|
||
| ! Check that SIMPLE is recognized in the parse tree | ||
|
|
||
| simple function foo() | ||
| return | ||
| end function | ||
|
|
||
| ! CHECK: Simple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| ! RUN: not %flang_fc1 -fsyntax-only %s 2>&1 | FileCheck %s | ||
| ! | ||
| ! Verify that PURE and SIMPLE prefix-specs are mutually exclusive | ||
|
|
||
| pure simple subroutine ps() | ||
| end | ||
| ! CHECK: error: Attributes 'PURE' and 'SIMPLE' conflict | ||
|
|
||
| simple pure function sp() | ||
| end | ||
| ! CHECK: error: Attributes 'PURE' and 'SIMPLE' conflict | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because all SIMPLE procedures are also PURE, an explicit SIMPLE attribute should also set the PURE attribute. There is a mechanism whereby one can mark a symbol with an attribute and note that it is implicit.