Skip to content

[clang-sycl-linker] Generate SymbolTable for each image #161287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

[clang-sycl-linker] Generate SymbolTable for each image #161287

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d07251d
[clang-sycl-linker] Generate SymbolTable for each image
YuriPlyakhin Sep 29, 2025
c383c6b
added TODO comments
YuriPlyakhin Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion clang/tools/clang-sycl-linker/ClangSYCLLinker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,12 @@ static Error runAOTCompile(StringRef InputFile, StringRef OutputFile,
return createStringError(inconvertibleErrorCode(), "Unsupported arch");
}

bool isKernel(const Function &F) {
const CallingConv::ID CC = F.getCallingConv();
return CC == CallingConv::SPIR_KERNEL || CC == CallingConv::AMDGPU_KERNEL ||
CC == CallingConv::PTX_Kernel;
}

/// Performs the following steps:
/// 1. Link input device code (user code and SYCL device library code).
/// 2. Run SPIR-V code generation.
Expand All @@ -486,6 +492,22 @@ Error runSYCLLink(ArrayRef<std::string> Files, const ArgList &Args) {
SmallVector<std::string> SplitModules;
SplitModules.emplace_back(*LinkedFile);

// Generate symbol table.
SmallVector<std::string> SymbolTable;
for (size_t I = 0, E = SplitModules.size(); I != E; ++I) {
Expected<std::unique_ptr<Module>> ModOrErr =
getBitcodeModule(SplitModules[I], C);
if (!ModOrErr)
return ModOrErr.takeError();

SmallVector<StringRef> Symbols;
for (Function &F : **ModOrErr) {
if (isKernel(F))
Symbols.push_back(F.getName());
}
SymbolTable.emplace_back(llvm::join(Symbols.begin(), Symbols.end(), "\n"));
}

bool IsAOTCompileNeeded = IsIntelOffloadArch(
StringToOffloadArch(Args.getLastArgValue(OPT_arch_EQ)));

Expand Down Expand Up @@ -523,12 +545,13 @@ Error runSYCLLink(ArrayRef<std::string> Files, const ArgList &Args) {
return createFileError(File, EC);
}
OffloadingImage TheImage{};
TheImage.TheImageKind = IMG_Object;
TheImage.TheImageKind = IMG_None;
TheImage.TheOffloadKind = OFK_SYCL;
TheImage.StringData["triple"] =
Args.MakeArgString(Args.getLastArgValue(OPT_triple_EQ));
TheImage.StringData["arch"] =
Args.MakeArgString(Args.getLastArgValue(OPT_arch_EQ));
TheImage.StringData["symbols"] = SymbolTable[I];
TheImage.Image = std::move(*FileOrErr);

llvm::SmallString<0> Buffer = OffloadBinary::write(TheImage);
Expand Down