Skip to content

[ARM] Recognize abi tag module flags #161306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+33 −6
Open

[ARM] Recognize abi tag module flags #161306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e92973
[ARM] Recognize some module flags
paperchalice Sep 29, 2025
0afe4bc
address comments
paperchalice Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions llvm/lib/Target/ARM/ARMAsmPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,8 +702,13 @@ void ARMAsmPrinter::emitAttributes() {
}

// Set FP Denormals.
if (checkDenormalAttributeConsistency(*MMI->getModule(), "denormal-fp-math",
DenormalMode::getPreserveSign()))
if (auto *DM = mdconst::extract_or_null<ConstantInt>(
MMI->getModule()->getModuleFlag("arm-eabi-fp-denormal"))) {
if (unsigned TagVal = DM->getZExtValue())
ATS.emitAttribute(ARMBuildAttrs::ABI_FP_denormal, TagVal);
} else if (checkDenormalAttributeConsistency(*MMI->getModule(),
"denormal-fp-math",
DenormalMode::getPreserveSign()))
ATS.emitAttribute(ARMBuildAttrs::ABI_FP_denormal,
ARMBuildAttrs::PreserveFPSign);
else if (checkDenormalAttributeConsistency(*MMI->getModule(),
Expand Down Expand Up @@ -743,9 +748,13 @@ void ARMAsmPrinter::emitAttributes() {
}

// Set FP exceptions and rounding
if (checkFunctionsAttributeConsistency(*MMI->getModule(),
"no-trapping-math", "true") ||
TM.Options.NoTrappingFPMath)
if (auto *Ex = mdconst::extract_or_null<ConstantInt>(
MMI->getModule()->getModuleFlag("arm-eabi-fp-exceptions"))) {
if (unsigned TagVal = Ex->getZExtValue())
ATS.emitAttribute(ARMBuildAttrs::ABI_FP_exceptions, Ex->getZExtValue());
} else if (checkFunctionsAttributeConsistency(*MMI->getModule(),
"no-trapping-math", "true") ||
TM.Options.NoTrappingFPMath)
ATS.emitAttribute(ARMBuildAttrs::ABI_FP_exceptions,
ARMBuildAttrs::Not_Allowed);
else {
Expand All @@ -759,7 +768,11 @@ void ARMAsmPrinter::emitAttributes() {

// TM.Options.NoInfsFPMath && TM.Options.NoNaNsFPMath is the
// equivalent of GCC's -ffinite-math-only flag.
if (TM.Options.NoInfsFPMath && TM.Options.NoNaNsFPMath)
if (auto *NumModel = mdconst::extract_or_null<ConstantInt>(
MMI->getModule()->getModuleFlag("arm-eabi-fp-number-model"))) {
if (unsigned TagVal = NumModel->getZExtValue())
ATS.emitAttribute(ARMBuildAttrs::ABI_FP_number_model, TagVal);
} else if (TM.Options.NoInfsFPMath && TM.Options.NoNaNsFPMath)
ATS.emitAttribute(ARMBuildAttrs::ABI_FP_number_model,
ARMBuildAttrs::Allowed);
else
Expand Down
14 changes: 14 additions & 0 deletions llvm/test/CodeGen/ARM/build-attributes-module.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
; RUN: llc %s -mtriple=arm-none-none-eabi -o - | FileCheck %s

define void @f() {
ret void
}

!llvm.module.flags = !{!0, !1, !2}

; CHECK: .eabi_attribute 20, 0
!0 = !{i32 2, !"arm-eabi-fp-denormal", i32 0}
; CHECK: .eabi_attribute 21, 1
!1 = !{i32 2, !"arm-eabi-fp-exceptions", i32 1}
; CHECK: .eabi_attribute 23, 1
!2 = !{i32 2, !"arm-eabi-fp-number-model", i32 1}
Loading