Skip to content

[libc++] Fix <__algorithm/find.h> when using -flax-vector-conversions=none #161362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
+7 −1
Merged

[libc++] Fix <__algorithm/find.h> when using -flax-vector-conversions=none #161362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/include/__algorithm/find.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ _LIBCPP_CONSTEXPR_SINCE_CXX14 _Tp* __find_vectorized(_Tp* __first, _Tp* __last,

auto __orig_first = __first;

auto __values = static_cast<__simd_vector<_Up, __vec_size>>(__value); // broadcast the value
auto __values = static_cast<__simd_vector<_Tp, __vec_size>>(__value); // broadcast the value
while (static_cast<size_t>(__last - __first) >= __unroll_count * __vec_size) [[__unlikely__]] {
__vec __lhs[__unroll_count];

Expand Down
3 changes: 3 additions & 0 deletions libcxx/test/std/experimental/simd/simd.class/simd_unary.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
// Assertion failed: N->getValueType(0) == MVT::v1i1 && "Expected v1i1 type"
// XFAIL: target=armv7-unknown-linux-gnueabihf

// FIXME: This should work with -flax-vector-conversions=none
// ADDITIONAL_COMPILE_FLAGS(clang): -flax-vector-conversions=integer

// <experimental/simd>
//
// [simd.class]
Expand Down
3 changes: 3 additions & 0 deletions libcxx/utils/libcxx/test/params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@

# We're not annotating all the APIs, since that's a lot of annotations compared to how many we actually care about
"-Wno-nullability-completeness",

# Technically not a warning flag, but might as well be:
"-flax-vector-conversions=none",
]

_allStandards = ["c++03", "c++11", "c++14", "c++17", "c++20", "c++23", "c++26"]
Expand Down
Loading